Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36686 )
Change subject: include/device: add pci mmio cfg address helpers ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36686/3/src/include/device/pci_mmio... File src/include/device/pci_mmio_cfg.h:
https://review.coreboot.org/c/coreboot/+/36686/3/src/include/device/pci_mmio... PS3, Line 90: uint8_t *pci_mmio_config8_addr(pci_devfn_t dev, uint16_t reg) Can we add commentary here, saying caching the pointer returned here is forbidden?
The address returned is dependent of both the MMCONF base address and the assigned PCI bus number of the requested device. We should not really treat those as constants.
-
Kyösti Mälkki (Code Review)