Change in ...coreboot[master]: nb/intel/gm45: Use a common romstage

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31190 )

Change subject: nb/intel/gm45: Use a common romstage
......................................................................


Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/31190/4/src/northbridge/intel/gm45/gm45.h 
File src/northbridge/intel/gm45/gm45.h:

https://review.coreboot.org/#/c/31190/4/src/northbridge/intel/gm45/gm45.h@44... 
PS4, Line 443: void mb_pre_raminit_setup(sysinfo_t *); /* optional */
function definition argument 'sysinfo_t *' should also have an identifier name



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/31190
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I30ef7f6962aabde78b5c40e0b53bb85e01c254c1
Gerrit-Change-Number: 31190
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Alexander Couzens <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Martin Roth <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: Patrick Rudolph <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Tue, 05 Feb 2019 12:34:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment