Attention is currently required from: Jan Tatje, Nico Huber, Angel Pons. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56071 )
Change subject: supermicro/x11-lga1151-series: Remove SkipExtGfxScan = 1 ......................................................................
Patch Set 4:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56071/comment/6eb41959_e3854392 PS4, Line 7: Remove SkipExtGfxScan = 1 enable scanning for external graphics
https://review.coreboot.org/c/coreboot/+/56071/comment/abd066b4_ff66801a PS4, Line 9: , by dropping SkipExtGfxScan=1 and setting PrimaryDisplay=PEG. This allows...
https://review.coreboot.org/c/coreboot/+/56071/comment/916ef858_da637107 PS4, Line 11: devicetree. maybe add this? ', so all four boards can make use of of the text framebuffer and/or a graphics card in a PEG slot.'
File src/mainboard/supermicro/x11-lga1151-series/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/56071/comment/82eb0a83_e0071c6f PS4, Line 3: # Additional FSP Configuration nit: you can drop that if you wish. it doesn't (and didn't) provide any value
https://review.coreboot.org/c/coreboot/+/56071/comment/3e72c29e_6b0220b2 PS4, Line 4: # This board has an IGD with no output. yeah, but this does not explain why we have PEG. What about adding "Display_PEG allows using the VGA text framebuffer and a graphics card in a PEG slot." or so?
https://review.coreboot.org/c/coreboot/+/56071/comment/e439af68_765f84b0 PS4, Line 43: off would you mind adding a follow-up change that enables this and drops it from the variants?
-
Michael Niewöhner (Code Review)