Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Paul Menzel, Julius Werner, Aaron Durbin, Felix Held. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49468 )
Change subject: soc/amd/picasso: fix CBFS MCACHE on Zork ......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/49468/comment/7b48d217_28878ba1 PS3, Line 7: vboot: fix CBFS MCACHE on zork
Please use soc/amd/picasso as the prefix.
Done
https://review.coreboot.org/c/coreboot/+/49468/comment/23897b6f_e71821c2 PS3, Line 9: Three things are fixed in this patch:
Use active: Fix three things in this patch […]
Done
https://review.coreboot.org/c/coreboot/+/49468/comment/1657db36_c8b3c8fd PS3, Line 11: * Call vboot_run_logic instead of verstage_main in psp_verstage. : vboot_run_logic will handle RW mcache build by calling after_verstage. : : * replace cbfs low-level apis to cbfs_map : cbfs_map will handle RO mcache build. : : * call update_boot_region before save_buffers : This will make RO mcache to be transferred to x86.
Listing/Enumerating changes, often indicates, that the commit should be split into exactly these ite […]
While I generally agree on that, the device didn't boot with only part of this change. Isn't it also good to keep every changes to a working state?
-
Kangheui Won (Code Review)