Attention is currently required from: Arthur Heymans, Christian Walter, Felix Held, Krystian Hebel, Martin Roth, Matt DeVillier, Michał Kopeć.
Filip Lewiński has posted comments on this change by Filip Lewiński. ( https://review.coreboot.org/c/coreboot/+/82037?usp=email )
Change subject: security/tpm: Add TPM2 NV_ReadPublic command support ......................................................................
Patch Set 17:
(5 comments)
File src/security/tpm/tss.h:
https://review.coreboot.org/c/coreboot/+/82037/comment/fbc06283_7fe6b0a6?usp... : PS16, Line 34: index
`space_index`?
[Done](https://review.coreboot.org/c/coreboot/+/82037/16..17/src/security/tpm/tss.h...)
https://review.coreboot.org/c/coreboot/+/82037/comment/c557ce3e_404c3732?usp... : PS16, Line 35: hte
the
[Done](https://review.coreboot.org/c/coreboot/+/82037/16..17/src/security/tpm/tss.h...)
File src/security/tpm/tss/tcg-2.0/tss.c:
https://review.coreboot.org/c/coreboot/+/82037/comment/95258660_73b7ee49?usp... : PS16, Line 395: struct nv_read_public_response *nvrp_resp)
One more space required to align it with the inside of the bracket.
[Done](https://review.coreboot.org/c/coreboot/+/82037/16..17/src/security/tpm/tss/t...)
https://review.coreboot.org/c/coreboot/+/82037/comment/399114ae_64a397f3?usp... : PS16, Line 410: return TPM_CB_NO_DEVICE;
I think this should normally be TPM_IOERROR (or maybe TPM_CB_READ_FAILURE).
[Done](https://review.coreboot.org/c/coreboot/+/82037/16..17/src/security/tpm/tss/t...)
https://review.coreboot.org/c/coreboot/+/82037/comment/7ea14b02_a1d9d214?usp... : PS16, Line 423:
Drop this line.
[Done](https://review.coreboot.org/c/coreboot/+/82037/16..17/src/security/tpm/tss/t...)