[S] Change in coreboot[master]: drivers/spi/tpm: verify device supports TPM2 - coreboot-gerrit

12 Nov 2022


      Attention is currently required from: Michał Żygowski, Christian Walter, Julius Werner, Krystian Hebel.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69022 )
Change subject: drivers/spi/tpm: verify device supports TPM2
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/spi/tpm/tpm.c:
https://review.coreboot.org/c/coreboot/+/69022/comment/0f81577c_cd7938d0 
PS1, Line 458: 	if (tpm2_read_reg(TPM_INTF_ID_REG, &intf_id, sizeof(intf_id)) != CB_SUCCESS) {
...
Can we wrap this in an `if (!CONFIG(TPM_GOOGLE))`? Just because our TPMs haven't always been 100% ac […]
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/69022
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib2840a21b3be8928d39570281f86a0e26b38b5f9
Gerrit-Change-Number: 69022
Gerrit-PatchSet: 2
Gerrit-Owner: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Krystian Hebel krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Attention: Christian Walter christian.walter@9elements.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Krystian Hebel krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Sat, 12 Nov 2022 22:50:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner jwerner@chromium.org
Gerrit-MessageType: comment