Attention is currently required from: SH Kim. Hello SH Kim,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/59684
to review the following change.
Change subject: mb/google/dedede/var/bugzzy: Configure LTE GPIOs using FW_CONFIG ......................................................................
mb/google/dedede/var/bugzzy: Configure LTE GPIOs using FW_CONFIG
The NC configurations for LTE GPIOs cannot disable LTE function on LTE sku board by FW_CONFIG. This change sets LTE GPIO pads to output low to ensure that LTE can be disabled by FW_CONFIG.
BUG=b:207805851 BRANCH=dedede TEST=build firmware and see LTE can be disabled by FW_CONFIG
Signed-off-by: Seunghwan Kim sh_.kim@samsung.corp-partner.google.com Change-Id: I01f4d3c623cb7f1deb6264cb88774788417d291d --- M src/mainboard/google/dedede/variants/bugzzy/gpio.c 1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/59684/1
diff --git a/src/mainboard/google/dedede/variants/bugzzy/gpio.c b/src/mainboard/google/dedede/variants/bugzzy/gpio.c index a218c5e..0066ae6 100644 --- a/src/mainboard/google/dedede/variants/bugzzy/gpio.c +++ b/src/mainboard/google/dedede/variants/bugzzy/gpio.c @@ -56,9 +56,10 @@ };
static const struct pad_config lte_disable_pads[] = { - PAD_NC(GPP_A10, NONE), - PAD_NC(GPP_D0, NONE), - PAD_NC(GPP_H17, NONE), + + PAD_CFG_GPO(GPP_A10, 0, DEEP), + PAD_CFG_GPO(GPP_D0, 0, DEEP), + PAD_CFG_GPO(GPP_H17, 0, DEEP), };
const struct pad_config *variant_override_gpio_table(size_t *num)