Change in coreboot[master]: cpu/intel/model_2065x: Add missing CPU IDs

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38943 )

Change subject: cpu/intel/model_2065x: Add missing CPU IDs
......................................................................

cpu/intel/model_2065x: Add missing CPU IDs

The missing CPU IDs were found on CPU-World's database:

- 0x20650: http://www.cpu-world.com/cgi-bin/CPUID.pl?SIGNATURE=132688
- 0x20651: http://www.cpu-world.com/cgi-bin/CPUID.pl?SIGNATURE=132689
- 0x20652: http://www.cpu-world.com/cgi-bin/CPUID.pl?SIGNATURE=132690
- 0x20654: http://www.cpu-world.com/cgi-bin/CPUID.pl?SIGNATURE=132692
- 0x20655: http://www.cpu-world.com/cgi-bin/CPUID.pl?SIGNATURE=132693

Note that these CPUs are not Nehalem, but rather Arrandale on laptops
and Clarksdale on desktops, so also update the comments accordingly.

Change-Id: I285961b62b9a8ada5a1659cd9ad75f7075259664
Signed-off-by: Angel Pons 
---
M src/cpu/intel/model_2065x/model_2065x_init.c
1 file changed, 6 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/38943/1

diff --git a/src/cpu/intel/model_2065x/model_2065x_init.c b/src/cpu/intel/model_2065x/model_2065x_init.c
index b736943..93fcc46 100644
--- a/src/cpu/intel/model_2065x/model_2065x_init.c
+++ b/src/cpu/intel/model_2065x/model_2065x_init.c
@@ -342,9 +342,13 @@
    .init     = model_2065x_init,
 };

+/* Arrandale / Clarksdale CPU IDs */
 static const struct cpu_device_id cpu_table[] = {
-	{ X86_VENDOR_INTEL, 0x20652 }, /* Intel Nehalem */
-	{ X86_VENDOR_INTEL, 0x20655 }, /* Intel Nehalem */
+	{ X86_VENDOR_INTEL, 0x20650 },
+	{ X86_VENDOR_INTEL, 0x20651 },
+	{ X86_VENDOR_INTEL, 0x20652 },
+	{ X86_VENDOR_INTEL, 0x20654 },
+	{ X86_VENDOR_INTEL, 0x20655 },
    { 0, 0 },
 };

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38943 )

Change subject: cpu/intel/model_2065x: Add missing CPU IDs
......................................................................

Patch Set 1: Code-Review+1

[Jonathan Kollasch (Code Review)]

Jonathan Kollasch has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38943 )

Change subject: cpu/intel/model_2065x: Add missing CPU IDs
......................................................................

Patch Set 1: Code-Review+1

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38943 )

Change subject: cpu/intel/model_2065x: Add missing CPU IDs
......................................................................

Patch Set 2: Code-Review+1

(1 comment)

which one is Arrandale / Clarksdale ?

https://review.coreboot.org/c/coreboot/+/38943/2/src/cpu/intel/model_2065x/m... 
File src/cpu/intel/model_2065x/model_2065x_init.c:

https://review.coreboot.org/c/coreboot/+/38943/2/src/cpu/intel/model_2065x/m... 
PS2, Line 346: Nehalem
I'd rename with the right name.

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38943 )

Change subject: cpu/intel/model_2065x: Add missing CPU IDs
......................................................................

Patch Set 2:
> Patch Set 2: Code-Review+1
>
> (1 comment)
>
> which one is Arrandale / Clarksdale ?

Clarkdale is desktop, Arrandale is laptop. However, at least one of the CPU IDs applies to both Clarkdale and Arrandale, so it's hard to tell. Other IDs are only present on engineering samples.

[Angel Pons (Code Review)]

Hello Patrick Rudolph, HAOUAS Elyes, Jonathan Kollasch, Paul Menzel, build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38943

to look at the new patch set (#3).

Change subject: cpu/intel/model_2065x: Add missing CPU IDs
......................................................................

cpu/intel/model_2065x: Add missing CPU IDs

The missing CPU IDs were found on CPU-World's database:

- 0x20650: http://www.cpu-world.com/cgi-bin/CPUID.pl?SIGNATURE=132688
- 0x20651: http://www.cpu-world.com/cgi-bin/CPUID.pl?SIGNATURE=132689
- 0x20652: http://www.cpu-world.com/cgi-bin/CPUID.pl?SIGNATURE=132690
- 0x20654: http://www.cpu-world.com/cgi-bin/CPUID.pl?SIGNATURE=132692
- 0x20655: http://www.cpu-world.com/cgi-bin/CPUID.pl?SIGNATURE=132693

Note that these CPUs are not Nehalem, but rather Arrandale on laptops
and Clarksdale on desktops, so also update the comments accordingly.

Change-Id: I285961b62b9a8ada5a1659cd9ad75f7075259664
Signed-off-by: Angel Pons 
---
M src/cpu/intel/model_2065x/model_2065x_init.c
1 file changed, 6 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/38943/3

[Angel Pons (Code Review)]

Hello Patrick Rudolph, HAOUAS Elyes, Jonathan Kollasch, Paul Menzel, build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38943

to look at the new patch set (#4).

Change subject: cpu/intel/model_2065x: Add missing CPU IDs
......................................................................

cpu/intel/model_2065x: Add missing CPU IDs

The missing CPU IDs were found on CPU-World's database:

- 0x20650: http://www.cpu-world.com/cgi-bin/CPUID.pl?SIGNATURE=132688
- 0x20651: http://www.cpu-world.com/cgi-bin/CPUID.pl?SIGNATURE=132689
- 0x20652: http://www.cpu-world.com/cgi-bin/CPUID.pl?SIGNATURE=132690
- 0x20654: http://www.cpu-world.com/cgi-bin/CPUID.pl?SIGNATURE=132692
- 0x20655: http://www.cpu-world.com/cgi-bin/CPUID.pl?SIGNATURE=132693

Note that these CPUs are not Nehalem, but rather Arrandale on laptops
and Clarkdale on desktops, so also update the comments accordingly.

Change-Id: I285961b62b9a8ada5a1659cd9ad75f7075259664
Signed-off-by: Angel Pons 
---
M src/cpu/intel/model_2065x/model_2065x_init.c
1 file changed, 6 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/38943/4

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38943 )

Change subject: cpu/intel/model_2065x: Add missing CPU IDs
......................................................................

Patch Set 4:
> Patch Set 2:
> > Patch Set 2: Code-Review+1
> >
> > (1 comment)
> >
> > which one is Arrandale / Clarksdale ?
>
> Clarkdale is desktop, Arrandale is laptop. However, at least one of the CPU IDs applies to both Clarkdale and Arrandale, so it's hard to tell. Other IDs are only present on engineering samples.

Also, you made me realize I have misspelled "Clarkdale". Thanks!

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38943 )

Change subject: cpu/intel/model_2065x: Add missing CPU IDs
......................................................................

Patch Set 5: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38943 )

Change subject: cpu/intel/model_2065x: Add missing CPU IDs
......................................................................

cpu/intel/model_2065x: Add missing CPU IDs

The missing CPU IDs were found on CPU-World's database:

- 0x20650: http://www.cpu-world.com/cgi-bin/CPUID.pl?SIGNATURE=132688
- 0x20651: http://www.cpu-world.com/cgi-bin/CPUID.pl?SIGNATURE=132689
- 0x20652: http://www.cpu-world.com/cgi-bin/CPUID.pl?SIGNATURE=132690
- 0x20654: http://www.cpu-world.com/cgi-bin/CPUID.pl?SIGNATURE=132692
- 0x20655: http://www.cpu-world.com/cgi-bin/CPUID.pl?SIGNATURE=132693

Note that these CPUs are not Nehalem, but rather Arrandale on laptops
and Clarkdale on desktops, so also update the comments accordingly.

Change-Id: I285961b62b9a8ada5a1659cd9ad75f7075259664
Signed-off-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38943
Reviewed-by: Felix Held 
Tested-by: build bot (Jenkins) 
---
M src/cpu/intel/model_2065x/model_2065x_init.c
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Felix Held: Looks good to me, approved

diff --git a/src/cpu/intel/model_2065x/model_2065x_init.c b/src/cpu/intel/model_2065x/model_2065x_init.c
index b736943..e35d1e7 100644
--- a/src/cpu/intel/model_2065x/model_2065x_init.c
+++ b/src/cpu/intel/model_2065x/model_2065x_init.c
@@ -342,9 +342,13 @@
    .init     = model_2065x_init,
 };

+/* Arrandale / Clarkdale CPU IDs */
 static const struct cpu_device_id cpu_table[] = {
-	{ X86_VENDOR_INTEL, 0x20652 }, /* Intel Nehalem */
-	{ X86_VENDOR_INTEL, 0x20655 }, /* Intel Nehalem */
+	{ X86_VENDOR_INTEL, 0x20650 },
+	{ X86_VENDOR_INTEL, 0x20651 },
+	{ X86_VENDOR_INTEL, 0x20652 },
+	{ X86_VENDOR_INTEL, 0x20654 },
+	{ X86_VENDOR_INTEL, 0x20655 },
    { 0, 0 },
 };