Attention is currently required from: Nico Huber, Johnny Lin, Christian Walter, Andrey Petrov, Tim Chu.
Hello build bot (Jenkins), Nico Huber, Subrata Banik, Jonathan Zhang, Johnny Lin, Christian Walter, Andrey Petrov, Tim Chu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/69509
to look at the new patch set (#4).
Change subject: Revert "src/arch/x86: Use core apic id to get cpu_index()" ......................................................................
Revert "src/arch/x86: Use core apic id to get cpu_index()"
This reverts commit 095c931cf12924da9011b47aa64f4a6f11d89f13.
Previously cpu_info() was implemented with a struct on top of an aligned stack. As FSP changed the stack value cpu_info() could not be used in FSP context (which PPI is). Now cpu_info() uses GDT segments, which FSP does not touch so it can be used.
This also exports cpu_infos from cpu.c as it's a convenient way to get the struct device * for a certain index.
TESTED on aldrvp: FSP-S works and is able to run code on APs.
Change-Id: I3a40156ba275b572d7d1913d8c17c24b4c8f6d78 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/arch/x86/cpu.c M src/arch/x86/include/arch/cpu.h M src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c M src/soc/intel/xeon_sp/cpx/cpu.c M src/soc/intel/xeon_sp/skx/cpu.c 5 files changed, 42 insertions(+), 50 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/69509/4