Change in coreboot[master]: soc/intel/common/block/smm: add case intrusion to SMI handler
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39265 )
Change subject: soc/intel/common/block/smm: add case intrusion to SMI handler ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39265/6/src/soc/intel/common/block/... File src/soc/intel/common/block/smm/smihandler.c:
https://review.coreboot.org/c/coreboot/+/39265/6/src/soc/intel/common/block/... PS6, Line 434: if (!tco_sts)
I'm confused. […]
I guess what Michael meant is that it's only ever called in a TCO SMI, and so it shouldn't be called at all in a non-TCO_SMI config.
Going by that argument, maybe we should wrap "[TCO_STS_BIT] = smihandler_southbridge_tco" (where this function is hooked up in each chipset) with #if CONFIG(TCO_SMI)? That way this function can be eliminated altogether by the linker.
There's a null-check on members of southbridge_smi (where that array field ends up in), so AFAICS this would be safe.
-
Patrick Georgi (Code Review)