Attention is currently required from: Tim Wawrzynczak, Sumeet R Pawnikar.
Ariel Fang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59182 )
Change subject: mb/google/brya/var/primus: Update thermal table for primus
......................................................................
Patch Set 8:
(2 comments)
File src/mainboard/google/brya/variants/primus/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/59182/comment/9766e972_14464abf
PS7, Line 76: ## Disable Active Policy from baseboard
: register "policies.active" = "{[0] = {.target=DPTF_NONE}}"
There is no policy defined in the baseboard, so this change might not be required. […]
done
https://review.coreboot.org/c/coreboot/+/59182/comment/6c9aa7e8_641aa209
PS7, Line 82: CHARGER
This is mapped to which sensor, as per available lists at line 71 to 74 sensors.
I modify the TSR options and add the Charger define.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59182
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id4d8dbe678b7f0870aeffa0a0118e65de9d5c22d
Gerrit-Change-Number: 59182
Gerrit-PatchSet: 8
Gerrit-Owner: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Comment-Date: Tue, 23 Nov 2021 08:59:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment