Attention is currently required from: Julius Werner, Lean Sheng Tan.
Benjamin Doron has posted comments on this change by Benjamin Doron. ( https://review.coreboot.org/c/coreboot/+/85643?usp=email )
Change subject: commonlib/device_tree.c: Add a function that reads FDT ints ......................................................................
Patch Set 7:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85643/comment/7dbecf08_378dcda8?usp... : PS5, Line 13: /
typo
Done
File src/commonlib/device_tree.c:
https://review.coreboot.org/c/coreboot/+/85643/comment/a964e00c_8b4d8d58?usp... : PS5, Line 266: printk(BIOS_ERR, "FDT integer property of size %u @%p doesn't match expected cell count %u\n", prop->size, prop->data, cells);
Should at least drop the arguments after the format string into a continuation line.
Done
File src/commonlib/device_tree.c:
https://review.coreboot.org/c/coreboot/+/85643/comment/1b0e6277_05d06b7a?usp... : PS6, Line 267: printk(BIOS_DEBUG, "FDT integer property of size %u @%p is %u cells\n", prop->size, prop->data, cells);
I don't think we'll want to print this every time, it's just gonna be spam.
True, it's a very low-level detail about the FDT and also useful for debugging this code. I'll drop it.