Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48780 )
Change subject: soc/intel/{icl,tgl,adl,ehl,jsl}: move UART pad config to boards
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48780/5/src/mainboard/intel/adlrvp/...
File src/mainboard/intel/adlrvp/early_gpio.c:
PS5:
Chrome-EC variant only.
how do you know? just realized, adlrvp does not select lpss
https://review.coreboot.org/c/coreboot/+/48780/5/src/mainboard/intel/jasperl...
File src/mainboard/intel/jasperlake_rvp/variants/jslrvp/gpio.c:
PS5:
ChromeEC version only.
how do you know? just realized, jslrvp does not select lpss
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48780
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5150110dd13e9da981a0c8614ee642037e209ca4
Gerrit-Change-Number: 48780
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Seunghwan Kim
sh_.kim@samsung.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Chen
Tim-Chen@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 22 Dec 2020 00:35:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment