Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32890
Change subject: mb/asus/p8h61-m_pro: Small fixes ......................................................................
mb/asus/p8h61-m_pro: Small fixes
* Add VBT * Configure OnBoard NIC * Add documentation
Change-Id: Iad739b4e1dacb41f5f63247150951df7013bbf0c Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- A Documentation/mainboard/asus/p8h61-m_pro.jpg A Documentation/mainboard/asus/p8h61-m_pro.md M Documentation/mainboard/index.md M src/mainboard/asus/p8h61-m_pro/Kconfig M src/mainboard/asus/p8h61-m_pro/devicetree.cb 5 files changed, 113 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/32890/1
diff --git a/Documentation/mainboard/asus/p8h61-m_pro.jpg b/Documentation/mainboard/asus/p8h61-m_pro.jpg new file mode 100644 index 0000000..5023966 --- /dev/null +++ b/Documentation/mainboard/asus/p8h61-m_pro.jpg Binary files differ diff --git a/Documentation/mainboard/asus/p8h61-m_pro.md b/Documentation/mainboard/asus/p8h61-m_pro.md new file mode 100644 index 0000000..cc53af6 --- /dev/null +++ b/Documentation/mainboard/asus/p8h61-m_pro.md @@ -0,0 +1,102 @@ +# ASUS P8H61-M Pro + +This page describes how to run coreboot on the [ASUS P8H61-M Pro]. + +## Flashing coreboot + +```eval_rst ++---------------------+------------+ +| Type | Value | ++=====================+============+ +| Socketed flash | yes | ++---------------------+------------+ +| Model | W25Q32BV | ++---------------------+------------+ +| Size | 4 MiB | ++---------------------+------------+ +| Package | DIP-8 | ++---------------------+------------+ +| Write protection | no | ++---------------------+------------+ +| Dual BIOS feature | no | ++---------------------+------------+ +| Internal flashing | yes | ++---------------------+------------+ +``` + +The flash IC is located right next to one of the SATA ports: + + +### Internal programming + +The main SPI flash can be accessed using [flashrom]. By default, only +the BIOS region of the flash is writable. If you wish to change any +other region (Management Engine or flash descriptor), then an external +programmer is required. + +The following command may be used to flash coreboot: + +``` +$ sudo flashrom --noverify-all --ifd -i bios -p internal -w coreboot.rom +``` + +The use of `--noverify-all` is required since the Management Engine +region is not readable even by the host. + +## Known issues + +- There is no automatic, OS-independent fan control. This is because + the super I/O hardware monitor can only obtain valid CPU temperature + readings from the PECI agent, whose complete initialisation is not + publicly documented. The `coretemp` driver can still be used for + accurate CPU temperature readings. + +- me_cleaner breaks LPC bus and attached components! + +## Untested + +- PCIe graphics +- parallel port +- PS/2 keyboard +- EHCI debug +- S/PDIF audio + +## Working + +- USB +- Gigabit Ethernet +- Integrated graphics +- SATA +- Serial port +- hardware monitor (see [Known issues](#known-issues) for caveats) +- front panel audio +- Native raminit (2 x 2GB, DDR3-1333) +- Native graphics init (libgfxinit) +- Wake-on-LAN +- TPM on TPM-header + +## Technology + +```eval_rst ++------------------+--------------------------------------------------+ +| Northbridge | :doc:`../../northbridge/intel/sandybridge/index` | ++------------------+--------------------------------------------------+ +| Southbridge | bd82x6x | ++------------------+--------------------------------------------------+ +| CPU | model_206ax | ++------------------+--------------------------------------------------+ +| Super I/O | Nuvoton NCT6776 | ++------------------+--------------------------------------------------+ +| EC | None | ++------------------+--------------------------------------------------+ +| Coprocessor | Intel Management Engine | ++------------------+--------------------------------------------------+ +``` + +## Extra resources + +- [Flash chip datasheet][W25Q32BV] + +[ASUS P8H61-M Pro]: https://www.asus.com/Motherboards/P8H61M_Pro/ +[W25Q32BV]: https://www.winbond.com/resource-files/w25q32bv_revi_100413_wo_automotive.pd... +[flashrom]: https://flashrom.org/Flashrom diff --git a/Documentation/mainboard/index.md b/Documentation/mainboard/index.md index 9af5c80..20578729 100644 --- a/Documentation/mainboard/index.md +++ b/Documentation/mainboard/index.md @@ -6,6 +6,7 @@
- [F2A85-M](asus/f2a85-m.md) - [P8H61-M LX](asus/p8h61-m_lx.md) +- [P8H61-M Pro](asus/p8h61-m_pro.md)
## ASRock
diff --git a/src/mainboard/asus/p8h61-m_pro/Kconfig b/src/mainboard/asus/p8h61-m_pro/Kconfig index 14f841e..e8a6f64 100644 --- a/src/mainboard/asus/p8h61-m_pro/Kconfig +++ b/src/mainboard/asus/p8h61-m_pro/Kconfig @@ -31,6 +31,9 @@ select HAVE_CMOS_DEFAULT select DRIVERS_ASMEDIA_ASPM_BLACKLIST select MAINBOARD_HAS_LPC_TPM + select REALTEK_8168_RESET + select RT8168_SET_LED_MODE + select INTEL_GMA_HAVE_VBT
config MAINBOARD_DIR string diff --git a/src/mainboard/asus/p8h61-m_pro/devicetree.cb b/src/mainboard/asus/p8h61-m_pro/devicetree.cb index f853452..d3f1795 100644 --- a/src/mainboard/asus/p8h61-m_pro/devicetree.cb +++ b/src/mainboard/asus/p8h61-m_pro/devicetree.cb @@ -49,7 +49,13 @@ device pci 1b.0 on end # High Definition Audio Audio controller device pci 1c.0 on end # PCIe x1 Port (PCIEX1_1) device pci 1c.1 on end # PCIe x1 Port (PCIEX1_2) - device pci 1c.2 on end # Realtek RTL8111E Ethernet Controller + device pci 1c.2 on # Realtek RTL8111E Ethernet Controller + chip drivers/net + register "customized_leds" = "0x00f6" + register "wake" = "9" + device pci 00.0 on end + end + end device pci 1c.3 on end # ASMedia ASM1042 USB3 Controller device pci 1c.4 on end # PCIe x1 Port, x16 size (PCIEX16_2) device pci 1c.5 on end # ASMedia ASM1062 SATA Controller
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32890 )
Change subject: mb/asus/p8h61-m_pro: Small fixes ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32890/1/Documentation/mainboard/asus/p8h61-m... File Documentation/mainboard/asus/p8h61-m_pro.jpg:
PS1: can you reduce the file size?
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32890 )
Change subject: mb/asus/p8h61-m_pro: Small fixes ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32890/1/Documentation/mainboard/asus/p8h61-m... File Documentation/mainboard/asus/p8h61-m_pro.jpg:
PS1:
can you reduce the file size?
jpegoptim -s -m 60 p8h61-m_pro.jpg reduces it to 70k here with negligible quality loss.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32890 )
Change subject: mb/asus/p8h61-m_pro: Small fixes ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
https://review.coreboot.org/#/c/32890/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32890/1//COMMIT_MSG@9 PS1, Line 9: * Add VBT Is it added, though?
https://review.coreboot.org/#/c/32890/1/Documentation/mainboard/asus/p8h61-m... File Documentation/mainboard/asus/p8h61-m_pro.md:
https://review.coreboot.org/#/c/32890/1/Documentation/mainboard/asus/p8h61-m... PS1, Line 58: - PCIe graphics Last time I tested this it was working
https://review.coreboot.org/#/c/32890/1/Documentation/mainboard/asus/p8h61-m... PS1, Line 60: - PS/2 keyboard This was working too
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32890 )
Change subject: mb/asus/p8h61-m_pro: Small fixes ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32890/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32890/1//COMMIT_MSG@7 PS1, Line 7: mb/asus/p8h61-m_pro: Small fixes
Do small fixes
Add small fixes
Fix small things
Hello Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32890
to look at the new patch set (#2).
Change subject: mb/asus/p8h61-m_pro: Add small fixes ......................................................................
mb/asus/p8h61-m_pro: Add small fixes
* Add VBT * Configure OnBoard NIC * Add documentation
Change-Id: Iad739b4e1dacb41f5f63247150951df7013bbf0c Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- A Documentation/mainboard/asus/p8h61-m_pro.jpg A Documentation/mainboard/asus/p8h61-m_pro.md M Documentation/mainboard/index.md M src/mainboard/asus/p8h61-m_pro/Kconfig A src/mainboard/asus/p8h61-m_pro/data.vbt M src/mainboard/asus/p8h61-m_pro/devicetree.cb 6 files changed, 114 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/32890/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32890 )
Change subject: mb/asus/p8h61-m_pro: Add small fixes ......................................................................
Patch Set 2: Code-Review+1
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32890 )
Change subject: mb/asus/p8h61-m_pro: Add small fixes ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/#/c/32890/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32890/1//COMMIT_MSG@7 PS1, Line 7: mb/asus/p8h61-m_pro: Small fixes
Do small fixes […]
Done
https://review.coreboot.org/#/c/32890/1//COMMIT_MSG@9 PS1, Line 9: * Add VBT
Is it added, though?
Done
https://review.coreboot.org/#/c/32890/1/Documentation/mainboard/asus/p8h61-m... File Documentation/mainboard/asus/p8h61-m_pro.jpg:
PS1:
jpegoptim -s -m 60 p8h61-m_pro.jpg reduces it to 70k here with negligible quality loss.
Done
https://review.coreboot.org/#/c/32890/1/Documentation/mainboard/asus/p8h61-m... File Documentation/mainboard/asus/p8h61-m_pro.md:
https://review.coreboot.org/#/c/32890/1/Documentation/mainboard/asus/p8h61-m... PS1, Line 58: - PCIe graphics
Last time I tested this it was working
Done
https://review.coreboot.org/#/c/32890/1/Documentation/mainboard/asus/p8h61-m... PS1, Line 60: - PS/2 keyboard
This was working too
Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32890 )
Change subject: mb/asus/p8h61-m_pro: Add small fixes ......................................................................
Patch Set 2: Code-Review+2
Patrick Rudolph has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32890 )
Change subject: mb/asus/p8h61-m_pro: Add small fixes ......................................................................
mb/asus/p8h61-m_pro: Add small fixes
* Add VBT * Configure OnBoard NIC * Add documentation
Change-Id: Iad739b4e1dacb41f5f63247150951df7013bbf0c Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32890 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com --- A Documentation/mainboard/asus/p8h61-m_pro.jpg A Documentation/mainboard/asus/p8h61-m_pro.md M Documentation/mainboard/index.md M src/mainboard/asus/p8h61-m_pro/Kconfig A src/mainboard/asus/p8h61-m_pro/data.vbt M src/mainboard/asus/p8h61-m_pro/devicetree.cb 6 files changed, 114 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/Documentation/mainboard/asus/p8h61-m_pro.jpg b/Documentation/mainboard/asus/p8h61-m_pro.jpg new file mode 100644 index 0000000..f3d6007 --- /dev/null +++ b/Documentation/mainboard/asus/p8h61-m_pro.jpg Binary files differ diff --git a/Documentation/mainboard/asus/p8h61-m_pro.md b/Documentation/mainboard/asus/p8h61-m_pro.md new file mode 100644 index 0000000..169678e --- /dev/null +++ b/Documentation/mainboard/asus/p8h61-m_pro.md @@ -0,0 +1,103 @@ +# ASUS P8H61-M Pro + +This page describes how to run coreboot on the [ASUS P8H61-M Pro]. + +## Flashing coreboot + +```eval_rst ++---------------------+------------+ +| Type | Value | ++=====================+============+ +| Socketed flash | yes | ++---------------------+------------+ +| Model | W25Q32BV | ++---------------------+------------+ +| Size | 4 MiB | ++---------------------+------------+ +| Package | DIP-8 | ++---------------------+------------+ +| Write protection | no | ++---------------------+------------+ +| Dual BIOS feature | no | ++---------------------+------------+ +| Internal flashing | yes | ++---------------------+------------+ +``` + +The flash IC is located right next to one of the SATA ports: + + +### Internal programming + +The main SPI flash can be accessed using [flashrom]. By default, only +the BIOS region of the flash is writable. If you wish to change any +other region (Management Engine or flash descriptor), then an external +programmer is required. + +The following command may be used to flash coreboot: + +``` +$ sudo flashrom --noverify-all --ifd -i bios -p internal -w coreboot.rom +``` + +The use of `--noverify-all` is required since the Management Engine +region is not readable even by the host. + +## Known issues + +- There is no automatic, OS-independent fan control. This is because + the super I/O hardware monitor can only obtain valid CPU temperature + readings from the PECI agent, whose complete initialisation is not + publicly documented. The `coretemp` driver can still be used for + accurate CPU temperature readings. + +- me_cleaner breaks LPC bus and attached components! +- PS/2 mouse doesn't work + +## Untested + +- parallel port +- EHCI debug +- S/PDIF audio + +## Working + +- PS/2 keyboard +- PCIe graphics +- USB +- Gigabit Ethernet +- Integrated graphics +- SATA +- Serial port +- hardware monitor (see [Known issues](#known-issues) for caveats) +- front panel audio +- Native raminit (2 x 2GB, DDR3-1333) +- Native graphics init (libgfxinit) +- Wake-on-LAN +- TPM on TPM-header + +## Technology + +```eval_rst ++------------------+--------------------------------------------------+ +| Northbridge | :doc:`../../northbridge/intel/sandybridge/index` | ++------------------+--------------------------------------------------+ +| Southbridge | bd82x6x | ++------------------+--------------------------------------------------+ +| CPU | model_206ax | ++------------------+--------------------------------------------------+ +| Super I/O | Nuvoton NCT6776 | ++------------------+--------------------------------------------------+ +| EC | None | ++------------------+--------------------------------------------------+ +| Coprocessor | Intel Management Engine | ++------------------+--------------------------------------------------+ +``` + +## Extra resources + +- [Flash chip datasheet][W25Q32BV] + +[ASUS P8H61-M Pro]: https://www.asus.com/Motherboards/P8H61M_Pro/ +[W25Q32BV]: https://www.winbond.com/resource-files/w25q32bv_revi_100413_wo_automotive.pd... +[flashrom]: https://flashrom.org/Flashrom diff --git a/Documentation/mainboard/index.md b/Documentation/mainboard/index.md index eced749..1494e06 100644 --- a/Documentation/mainboard/index.md +++ b/Documentation/mainboard/index.md @@ -6,6 +6,7 @@
- [F2A85-M](asus/f2a85-m.md) - [P8H61-M LX](asus/p8h61-m_lx.md) +- [P8H61-M Pro](asus/p8h61-m_pro.md)
## ASRock
diff --git a/src/mainboard/asus/p8h61-m_pro/Kconfig b/src/mainboard/asus/p8h61-m_pro/Kconfig index 14f841e..e8a6f64 100644 --- a/src/mainboard/asus/p8h61-m_pro/Kconfig +++ b/src/mainboard/asus/p8h61-m_pro/Kconfig @@ -31,6 +31,9 @@ select HAVE_CMOS_DEFAULT select DRIVERS_ASMEDIA_ASPM_BLACKLIST select MAINBOARD_HAS_LPC_TPM + select REALTEK_8168_RESET + select RT8168_SET_LED_MODE + select INTEL_GMA_HAVE_VBT
config MAINBOARD_DIR string diff --git a/src/mainboard/asus/p8h61-m_pro/data.vbt b/src/mainboard/asus/p8h61-m_pro/data.vbt new file mode 100644 index 0000000..114a840 --- /dev/null +++ b/src/mainboard/asus/p8h61-m_pro/data.vbt Binary files differ diff --git a/src/mainboard/asus/p8h61-m_pro/devicetree.cb b/src/mainboard/asus/p8h61-m_pro/devicetree.cb index f853452..d3f1795 100644 --- a/src/mainboard/asus/p8h61-m_pro/devicetree.cb +++ b/src/mainboard/asus/p8h61-m_pro/devicetree.cb @@ -49,7 +49,13 @@ device pci 1b.0 on end # High Definition Audio Audio controller device pci 1c.0 on end # PCIe x1 Port (PCIEX1_1) device pci 1c.1 on end # PCIe x1 Port (PCIEX1_2) - device pci 1c.2 on end # Realtek RTL8111E Ethernet Controller + device pci 1c.2 on # Realtek RTL8111E Ethernet Controller + chip drivers/net + register "customized_leds" = "0x00f6" + register "wake" = "9" + device pci 00.0 on end + end + end device pci 1c.3 on end # ASMedia ASM1042 USB3 Controller device pci 1c.4 on end # PCIe x1 Port, x16 size (PCIEX16_2) device pci 1c.5 on end # ASMedia ASM1062 SATA Controller
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)