Change in coreboot[master]: arch/x86/acpigen.c: Prevent null pointer dereference

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Angel Pons (Code Review)

8 Mar 2020 8 Mar '20

9:05 p.m.

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39387 )

Change subject: arch/x86/acpigen.c: Prevent null pointer dereference ......................................................................

arch/x86/acpigen.c: Prevent null pointer dereference

Change-Id: I7705d9a371b54f61b5050de34a05fe08a8989571 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/arch/x86/acpigen.c 1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/39387/1

diff --git a/src/arch/x86/acpigen.c b/src/arch/x86/acpigen.c index a599b0e..0abab11 100644 --- a/src/arch/x86/acpigen.c +++ b/src/arch/x86/acpigen.c @@ -288,6 +288,11 @@ int dotcount = 0, i; int dotpos = 0;

+ if (!namepath) { + printk(BIOS_ERR, "%s: namepath is NULL!\n"); + return; + } + /* We can start with a ''. */ if (namepath[0] == '\') { acpigen_emit_byte('\');

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

HAOUAS Elyes (Code Review)

9 Mar 9 Mar

12:40 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39387 )

Change subject: arch/x86/acpigen.c: Prevent null pointer dereference ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39387/1/src/arch/x86/acpigen.c File src/arch/x86/acpigen.c:

https://review.coreboot.org/c/coreboot/+/39387/1/src/arch/x86/acpigen.c@292 PS1, Line 292: ); ", __func__);" is missing?

-- To view, visit https://review.coreboot.org/c/coreboot/+/39387 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7705d9a371b54f61b5050de34a05fe08a8989571 Gerrit-Change-Number: 39387 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-Comment-Date: Mon, 09 Mar 2020 11:40:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

8:03 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39387 )

Change subject: arch/x86/acpigen.c: Prevent null pointer dereference ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39387/1/src/arch/x86/acpigen.c File src/arch/x86/acpigen.c:

https://review.coreboot.org/c/coreboot/+/39387/1/src/arch/x86/acpigen.c@292 PS1, Line 292: );

...

", __func__);" is missing?

It is.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39387 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7705d9a371b54f61b5050de34a05fe08a8989571 Gerrit-Change-Number: 39387 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 09 Mar 2020 19:03:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

Angel Pons (Code Review)

8:30 p.m.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39387

to look at the new patch set (#2).

Change subject: arch/x86/acpigen.c: Prevent null pointer dereference ......................................................................

arch/x86/acpigen.c: Prevent null pointer dereference

Change-Id: I7705d9a371b54f61b5050de34a05fe08a8989571 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/arch/x86/acpigen.c 1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/39387/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39387 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7705d9a371b54f61b5050de34a05fe08a8989571 Gerrit-Change-Number: 39387 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Angel Pons (Code Review)

8:30 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39387 )

Change subject: arch/x86/acpigen.c: Prevent null pointer dereference ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39387/1/src/arch/x86/acpigen.c File src/arch/x86/acpigen.c:

https://review.coreboot.org/c/coreboot/+/39387/1/src/arch/x86/acpigen.c@292 PS1, Line 292: );

...

It is.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/39387 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7705d9a371b54f61b5050de34a05fe08a8989571 Gerrit-Change-Number: 39387 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 09 Mar 2020 19:30:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

8:38 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39387 )

Change subject: arch/x86/acpigen.c: Prevent null pointer dereference ......................................................................

Patch Set 2:

There is a conflict with https://review.coreboot.org/c/coreboot/+/30098/4/src/arch/x86/acpigen.c

-- To view, visit https://review.coreboot.org/c/coreboot/+/39387 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7705d9a371b54f61b5050de34a05fe08a8989571 Gerrit-Change-Number: 39387 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 09 Mar 2020 19:38:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Angel Pons (Code Review)

23 May 23 May

11:44 p.m.

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39387 )

Change subject: arch/x86/acpigen.c: Prevent null pointer dereference ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/39387 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7705d9a371b54f61b5050de34a05fe08a8989571 Gerrit-Change-Number: 39387 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1802

days inactive

1878

days old

coreboot-gerrit@coreboot.org

6 comments

2 participants

tags (0)

participants (2)

Angel Pons (Code Review)
HAOUAS Elyes (Code Review)