Attention is currently required from: Tim Wawrzynczak, Kevin Chiu, Robert Chen, Wisley Chen, Shon Wang. Jimmy Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60275 )
Change subject: mb/google/brya/var/vell: Add MIPI camera support ......................................................................
Patch Set 4:
(4 comments)
File src/mainboard/google/brya/variants/vell/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/60275/comment/e84b96f8_1cf1a606 PS4, Line 133: 2 This value should be "4". We use 4 lane for ov8856 camera
https://review.coreboot.org/c/coreboot/+/60275/comment/8f0cb04d_e7b0904a PS4, Line 235: OVTI2740 Please change the HID name as "OVTI8856"
https://review.coreboot.org/c/coreboot/+/60275/comment/dd4e2fae_70154c30 PS4, Line 238: Ov 2740 Camera The chip name should be aligned with driver. Please change to "Ov 8856 Camera"
https://review.coreboot.org/c/coreboot/+/60275/comment/afaac5ac_15d5aed9 PS4, Line 242: register "ssdb.lanes_used" = "2" : register "ssdb.link_used" = "1" : register "num_freq_entries" = "1" : register "link_freq[0]" = "DEFAULT_LINK_FREQ" please correct to the below content to align with driver settings
register "ssdb.lanes_used" = "4" register "num_freq_entries" = "2" register "link_freq[0]" = "360000000" register "link_freq[1]" = "180000000"
-
Jimmy Su (Code Review)