Jarried Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86353?usp=email )
Change subject: soc/mediatek/mt8196: Fix issue of RTC recovery failed ......................................................................
soc/mediatek/mt8196: Fix issue of RTC recovery failed
Config pmic register 0x50c bit0 which decide whether use external xtal, this bit of mt6685 should be set to 1, which means without external xtal.
BRANCH=rauru BUG=b:395485005 TEST=emerge-rauru coreboot chromeos-bootimage, remove battery and charge, then insert battery and charge, rtc will boot normally
Signed-off-by: Shunxi Zhang ot_shunxi.zhang@mediatek.com Change-Id: Iea44f13af030f24c02993dd43a35a9d8b4f72179 --- M src/soc/mediatek/mt8196/mt6685_rtc.c 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/86353/1
diff --git a/src/soc/mediatek/mt8196/mt6685_rtc.c b/src/soc/mediatek/mt8196/mt6685_rtc.c index 4564a31..4e63f10 100644 --- a/src/soc/mediatek/mt8196/mt6685_rtc.c +++ b/src/soc/mediatek/mt8196/mt6685_rtc.c @@ -345,6 +345,10 @@ { printk(BIOS_INFO, "%s: enter\n", __func__);
+ config_interface(SCK_TOP_XTAL_SEL_ADDR, 1, SCK_TOP_XTAL_SEL_MASK, + SCK_TOP_XTAL_SEL_SHIFT); + udelay(100); + if (!retry(RECOVERY_RETRY_COUNT, rtc_frequency_meter_check() && rtc_init_after_recovery())) {