Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46249 )
Change subject: mb/clevo/l140cu: Correct FSP-M UPDs
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46249/1/src/mainboard/clevo/cml-u/v...
File src/mainboard/clevo/cml-u/variants/l140cu/romstage.c:
https://review.coreboot.org/c/coreboot/+/46249/1/src/mainboard/clevo/cml-u/v...
PS1, Line 10: .spd_spec = {.spd_index = 0},
nit: this is redundant, as the non-initialized struct members default to zero
already done in CB:46248 ;)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46249
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I32f1b7bb46eaaf0f0ecad1df310f5de988f64c85
Gerrit-Change-Number: 46249
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 10 Oct 2020 20:09:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment