Attention is currently required from: Cliff Huang, Jérémy Compostella, Pranava Y N, Wonkyu Kim.
Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84405?usp=email )
Change subject: mb/google/fatcat: Add GPIO settings
......................................................................
Patch Set 21:
(2 comments)
File src/mainboard/google/fatcat/variants/fatcat/gpio.c:
https://review.coreboot.org/c/coreboot/+/84405/comment/507cac3c_56d1d86b?usp... :
PS21, Line 253: overridden via fw_config
this is overdoing IMO.
https://review.coreboot.org/c/coreboot/+/84405/comment/6c8dff20_527a527e?usp... :
PS21, Line 412: /* GPP_C00: GPP_C0_SMBCLK */
: PAD_CFG_NF(GPP_C00, NONE, DEEP, NF1),
: /* GPP_C01: GPP_C1_SMBDATA */
: PAD_CFG_NF(GPP_C01, NONE, DEEP, NF1),
:
should this move into romstage ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84405?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d52
Gerrit-Change-Number: 84405
Gerrit-PatchSet: 21
Gerrit-Owner: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Cliff Huang
cliff.huang@intel.com
Gerrit-CC: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Tue, 01 Oct 2024 03:19:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No