[L] Change in coreboot[main]: soc/mediatek/mt8196: Add DDP driver

[Nancy Lin (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.

Nancy Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85950?usp=email )

Change subject: soc/mediatek/mt8196: Add DDP driver
......................................................................

Patch Set 4:

(9 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/85950/comment/9da1d0ec_0e648fac?usp... :
PS4, Line 9: controller
> IIUC DDP means "display datapath". […]

Yes, I should correct this. DDP stands for ”display data pipe“

File src/soc/mediatek/common/display.c:

https://review.coreboot.org/c/coreboot/+/85950/comment/13e7a3e2_a21d8a7e?usp... :
PS2, Line 46: __weak int mtk_edp_enable(void)
> Nancy, can I say that, `dptx_video_enable(true)` needs to be called after `mtk_ddp_mode_set` (I assu […]

Yes, you are right.

File src/soc/mediatek/mt8196/ddp.c:

https://review.coreboot.org/c/coreboot/+/85950/comment/86375c54_b4f7bb48?usp... :
PS3, Line 30: 	default:
> Print an error log here.

Ok, I will fix it.

https://review.coreboot.org/c/coreboot/+/85950/comment/62d3a728_2939e3b4?usp... :
PS3, Line 212: blender_config(i, width, height, blender_type[i]);
             : 		blender_start(i);
>

In Yidi's previous comment, he suggest to change to passing index to this function. Should I change back?

previous comment:
(https://chrome-internal-review.googlesource.com/c/chromeos/vendor/mtk-corebo...)

File src/soc/mediatek/mt8196/ddp.c:

https://review.coreboot.org/c/coreboot/+/85950/comment/141b5d28_de967672?usp... :
PS4, Line 268: clrsetbits32
> setbits32

OK, I will fix it.

https://review.coreboot.org/c/coreboot/+/85950/comment/631e9c23_9c4e8afb?usp... :
PS4, Line 269: clrsetbits32
> setbits32

OK, I will fix it.

File src/soc/mediatek/mt8196/include/soc/ddp.h:

https://review.coreboot.org/c/coreboot/+/85950/comment/63f22048_3f51f4a1?usp... :
PS3, Line 190: };
> one blank line below

OK, I will fix it.

https://review.coreboot.org/c/coreboot/+/85950/comment/d06d8e80_ba860e72?usp... :
PS3, Line 227: };
> blank line

OK, I will fix it.

https://review.coreboot.org/c/coreboot/+/85950/comment/b927c509_12b24521?usp... :
PS3, Line 254: };
> blank line

OK, I will fix it.