Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63003 )
Change subject: mb/google/skyrim: Fix Backlight GPIO ......................................................................
mb/google/skyrim: Fix Backlight GPIO
Backlight GPIO was set to HIGH, when it should have been set LOW to enable the backlight in the embedded display.
BUG=b:224618411 TEST=load on Skyrim proto1, observe backlight
Signed-off-by: Jon Murphy jpmurphy@google.com Change-Id: Ife3335ca5a3c2517a6817fccf0544e5fcacb1f9d Reviewed-on: https://review.coreboot.org/c/coreboot/+/63003 Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Karthik Ramasubramanian kramasub@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/skyrim/variants/baseboard/gpio.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/skyrim/variants/baseboard/gpio.c b/src/mainboard/google/skyrim/variants/baseboard/gpio.c index 204ddf6..d586405 100644 --- a/src/mainboard/google/skyrim/variants/baseboard/gpio.c +++ b/src/mainboard/google/skyrim/variants/baseboard/gpio.c @@ -61,7 +61,7 @@ /* EN_PP3300_TCHSCR */ PAD_GPO(GPIO_29, HIGH), /* SOC_DISABLE_DISP_BL */ - PAD_GPO(GPIO_30, HIGH), + PAD_GPO(GPIO_30, LOW), /* Unused */ PAD_NC(GPIO_31), /* LPC_RST_L */