Attention is currently required from: Xi Chen, Paul Menzel, Arthur Heymans.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74543 )
Change subject: vendorcode/mediatek/mt8192: Fix set but unused variables ......................................................................
Patch Set 5:
(4 comments)
File src/vendorcode/mediatek/mt8192/dramc/dramc_pi_basic_api.c:
https://review.coreboot.org/c/coreboot/+/74543/comment/280ff6f6_1f7c3d29 PS5, Line 274: emi_set I think this is used below.
https://review.coreboot.org/c/coreboot/+/74543/comment/26ec90ca_9137343b PS5, Line 305: #if (!__ETT__)//preloader : if(emi_setting_index == -1) : emi_set = &default_emi_setting; : else : emi_set = &emi_settings[emi_setting_index]; : #else//ett : emi_set = &default_emi_setting; : #endif : (void)emi_set; Can we remove all of these?
File src/vendorcode/mediatek/mt8192/include/x_hal_io.h:
https://review.coreboot.org/c/coreboot/+/74543/comment/0455c7ed_94ef155b PS5, Line 65: UINT16 upk = 1; \ Can we remove this variable?
https://review.coreboot.org/c/coreboot/+/74543/comment/c38aa8e3_19998992 PS5, Line 65: UINT16 upk = 1; \ Can we remove this variable?