Change in coreboot[master]: soc/intel/common/acpi: Correct IPC sub command for reading LPM requir... - coreboot-gerrit

23 Oct 2021


      Attention is currently required from: Ethan Tsao, Tim Wawrzynczak, Paul Menzel, Subrata Banik, Raj Astekar, Patrick Rudolph.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58317 )
Change subject: soc/intel/common/acpi: Correct IPC sub command for reading LPM requirement
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: 
the indentation of the new code looks a bit off to me. are you using a tab size of 8 locally for coreboot development? if not, that might explain this
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/58317
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I58509f14f1e67472adda78e65c3a2e3ee9210765
Gerrit-Change-Number: 58317
Gerrit-PatchSet: 1
Gerrit-Owner: Ethan Tsao ethan.tsao@intel.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Raj Astekar raj.astekar@intel.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Cliff Huang cliff.huang@intel.com
Gerrit-CC: Ethan Tsao ethan.tsao@intel.corp-partner.google.com
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Ethan Tsao ethan.tsao@intel.com
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik subrata.banik@intel.com
Gerrit-Attention: Raj Astekar raj.astekar@intel.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Sat, 23 Oct 2021 14:41:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment