[L] Change in coreboot[main]: include/device/device.h: Remove CHIP_NAME() macro - coreboot-gerrit

30 Jan 2024


      Attention is currently required from: Alexander Couzens, Angel Pons, Arthur Heymans, Caveh Jalali, Christian Walter, Dinesh Gehlot, Eran Mitrani, Felix Held, Forest Mittelberg, Fred Reitberger, Hung-Te Lin, Jakub Czapiga, Jason Glenesk, Jeff Daly, Jeremy Soller, Johnny Lin, Julius Werner, Jérémy Compostella, Kapil Porwal, Lean Sheng Tan, Matt DeVillier, Nicholas Chin, Nick Vaccaro, Philipp Hug, Sean Rhodes, Subrata Banik, Tarun, Tim Chu, Tim Crawford, Vanessa Eusebio, Werner Zeh, Xi Chen, Yidi Lin, Yu-Ping Wu, ron minnich.
Nicholas Sudsgaard has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80239?usp=email )
Change subject: include/device/device.h: Remove CHIP_NAME() macro
......................................................................
Patch Set 4:
(1 comment)
File src/soc/rockchip/rk3399/soc.c:
https://review.coreboot.org/c/coreboot/+/80239/comment/732c5874_9bdbfc78 :
PS3, Line 50:     .enable_dev = enable_soc_dev,
...
Can you fix the indentation over here? Thanks!
What's up with these weird indentations?
Done.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/80239?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0
Gerrit-Change-Number: 80239
Gerrit-PatchSet: 4
Gerrit-Owner: Nicholas Sudsgaard devel+coreboot@nsudsgaard.com
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Caveh Jalali caveh@chromium.org
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Dinesh Gehlot digehlot@google.com
Gerrit-Reviewer: Eran Mitrani mitrani@google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Forest Mittelberg bmbm@google.com
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Jakub Czapiga czapiga@google.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Jeff Daly jeffd@silicom-usa.com
Gerrit-Reviewer: Jeremy Soller jeremy@system76.com
Gerrit-Reviewer: Johnny Lin Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Nicholas Chin nic.c3.14@gmail.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Reviewer: Philipp Hug philipp@hug.cx
Gerrit-Reviewer: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tarun tstuli@gmail.com
Gerrit-Reviewer: Tim Chu Tim.Chu@quantatw.com
Gerrit-Reviewer: Tim Crawford tcrawford@system76.com
Gerrit-Reviewer: Vanessa Eusebio vanessa.f.eusebio@intel.com
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: ron minnich rminnich@gmail.com
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Eran Mitrani mitrani@google.com
Gerrit-Attention: Philipp Hug philipp@hug.cx
Gerrit-Attention: Jakub Czapiga czapiga@google.com
Gerrit-Attention: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Attention: Dinesh Gehlot digehlot@google.com
Gerrit-Attention: Nick Vaccaro nvaccaro@chromium.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Yidi Lin yidilin@google.com
Gerrit-Attention: Xi Chen xixi.chen@mediatek.com
Gerrit-Attention: Sean Rhodes sean@starlabs.systems
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Caveh Jalali caveh@chromium.org
Gerrit-Attention: Johnny Lin Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter christian.walter@9elements.com
Gerrit-Attention: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Attention: Alexander Couzens lynxis@fe80.eu
Gerrit-Attention: Nicholas Chin nic.c3.14@gmail.com
Gerrit-Attention: Werner Zeh werner.zeh@siemens.com
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Attention: ron minnich rminnich@gmail.com
Gerrit-Attention: Tim Chu Tim.Chu@quantatw.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Attention: Jeff Daly jeffd@silicom-usa.com
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Jeremy Soller jeremy@system76.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Tarun tstuli@gmail.com
Gerrit-Attention: Tim Crawford tcrawford@system76.com
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Kapil Porwal kapilporwal@google.com
Gerrit-Attention: Vanessa Eusebio vanessa.f.eusebio@intel.com
Gerrit-Attention: Forest Mittelberg bmbm@google.com
Gerrit-Comment-Date: Tue, 30 Jan 2024 13:01:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga czapiga@google.com
Gerrit-MessageType: comment