Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45119 )
Change subject: mb/system76/lemp9: Enable SataPortsDevSlp ......................................................................
mb/system76/lemp9: Enable SataPortsDevSlp
Enable SataPortsDevSlp for SATA ports 2 and 3.
Change-Id: Id6c69f4a6fe45cb5c6aad3f42c741a2724c6166c Signed-off-by: Felix Singer felixsinger@posteo.net --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/45119/1
diff --git a/src/mainboard/system76/lemp9/devicetree.cb b/src/mainboard/system76/lemp9/devicetree.cb index 621a284..e455f18 100644 --- a/src/mainboard/system76/lemp9/devicetree.cb +++ b/src/mainboard/system76/lemp9/devicetree.cb @@ -141,7 +141,9 @@ register "SataMode" = "Sata_AHCI" register "SataSalpSupport" = "0" register "SataPortsEnable[1]" = "1" + register "SataPortsDevSlp[1]" = "1" register "SataPortsEnable[2]" = "1" + register "SataPortsDevSlp[2]" = "1" end device pci 19.0 off end # I2C #4 device pci 19.1 off end # I2C #5
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45119 )
Change subject: mb/system76/lemp9: Enable SataPortsDevSlp ......................................................................
Patch Set 2: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45119 )
Change subject: mb/system76/lemp9: Enable SataPortsDevSlp ......................................................................
mb/system76/lemp9: Enable SataPortsDevSlp
Enable SataPortsDevSlp for SATA ports 2 and 3.
Change-Id: Id6c69f4a6fe45cb5c6aad3f42c741a2724c6166c Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/45119 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner --- M src/mainboard/system76/lemp9/devicetree.cb 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/system76/lemp9/devicetree.cb b/src/mainboard/system76/lemp9/devicetree.cb index f0cee06..6bece6d 100644 --- a/src/mainboard/system76/lemp9/devicetree.cb +++ b/src/mainboard/system76/lemp9/devicetree.cb @@ -178,7 +178,9 @@ register "SataMode" = "Sata_AHCI" register "SataSalpSupport" = "0" register "SataPortsEnable[1]" = "1" + register "SataPortsDevSlp[1]" = "1" register "SataPortsEnable[2]" = "1" + register "SataPortsDevSlp[2]" = "1" end device pci 19.0 off end # I2C #4 device pci 19.1 off end # I2C #5
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45119 )
Change subject: mb/system76/lemp9: Enable SataPortsDevSlp ......................................................................
Patch Set 4:
Automatic boot test returned (PASS/FAIL/TOTAL): 7/1/8 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/17937 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17936 "QEMU x86 i440fx/piix4" (x86_64) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/17935 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17934 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/17933 "HP Z220 SFF Workstation" (x86_32) using payload LinuxBoot_BusyBox_kexec : SUCCESS : https://lava.9esec.io/r/17940 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/17939 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/17938
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Felix Singer (Code Review)
-
Michael Niewöhner (Code Review)