Change in coreboot[master]: soc/mediatek/mt8183: Always run full calibration for debug DRAM issue...
huayang duan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36906 )
Change subject: soc/mediatek/mt8183: Always run full calibration for debug DRAM issue [DONOT MERGE] Disable fast calibration, that is always run full calibration for debug DRAM bitfilp issue. ......................................................................
soc/mediatek/mt8183: Always run full calibration for debug DRAM issue [DONOT MERGE] Disable fast calibration, that is always run full calibration for debug DRAM bitfilp issue.
BUG=b:80501386,b:142358843 BRANCH=kukui TEST=Boots correctly on Kukui
Change-Id: I693cfe98ea4317c4b856e9bb1f18046a10fe72f8 --- M src/soc/mediatek/mt8183/memory.c 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/36906/1
diff --git a/src/soc/mediatek/mt8183/memory.c b/src/soc/mediatek/mt8183/memory.c index 13c3d9a..fafe2a6 100644 --- a/src/soc/mediatek/mt8183/memory.c +++ b/src/soc/mediatek/mt8183/memory.c @@ -170,6 +170,11 @@ if (CONFIG(MT8183_DRAM_DVFS) && !recovery_mode) config |= DRAMC_CONFIG_DVFS;
+ +printk(BIOS_ERR, "DRAM-K: Force disable Fast Calibration for debug DRAM issue\n"); + +// disable fast calibration for debug DRAM issue +if (0) { /* Load calibration params from flash and run fast calibration */ if (recovery_mode) { printk(BIOS_WARNING, "Skip loading cached calibration data\n"); @@ -195,6 +200,7 @@ printk(BIOS_WARNING, "Failed to read calibration data from flash\n"); } +}
/* Run full calibration */ printk(BIOS_INFO, "DRAM-K: Full Calibration\n");
Hello Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/36906
to look at the new patch set (#2).
Change subject: soc/mediatek/mt8183: Always run full calibration for debug DRAM issue [DONOT MERGE] ......................................................................
soc/mediatek/mt8183: Always run full calibration for debug DRAM issue [DONOT MERGE]
Disable fast calibration, that is always run full calibration for debug DRAM bitfilp issue.
BUG=b:80501386,b:142358843 BRANCH=kukui TEST=Boots correctly on Kukui
Change-Id: I693cfe98ea4317c4b856e9bb1f18046a10fe72f8 --- M src/soc/mediatek/mt8183/memory.c 1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/36906/2
Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/36906?usp=email )
Change subject: soc/mediatek/mt8183: Always run full calibration for debug DRAM issue [DONOT MERGE] ......................................................................
Abandoned
-
huayang duan (Code Review) -
Stefan Reinauer (Code Review)