Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36087 )
Change subject: soc/intel/tigerlake: Do initial SoC commit ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36087/10/src/soc/intel/tigerlake/fs... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/36087/10/src/soc/intel/tigerlake/fs... PS10, Line 42: __weak
yes, because its not mandatory to have anyway mainboard override atleast few CRB i have seen where […]
let me start this non weak practice from TGL so we do force ppl to get used to it. SG?
https://review.coreboot.org/c/coreboot/+/36087/8/src/soc/intel/tigerlake/loc... File src/soc/intel/tigerlake/lockdown.c:
https://review.coreboot.org/c/coreboot/+/36087/8/src/soc/intel/tigerlake/loc... PS8, Line 20:
No, Inline comments only.
okay, let me do it. i hope at file top somewhere if we can document the chapter name and doc number is reasonable ?
-
Subrata Banik (Code Review)