Attention is currently required from: Felix Singer, Philipp Hug, Paul Menzel, Julius Werner, ron minnich, Elyes Haouas.
Philipp M has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74173 )
Change subject: arch/arm* Fix some linter warnings and errors ......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74173/comment/5d59eef9_9ff67928 PS1, Line 7: Fixed
Fix linter warnings and errors […]
Done
https://review.coreboot.org/c/coreboot/+/74173/comment/007b777d_ada76c7e PS1, Line 7: src/arch/ Fixed some linter warnings and errors
Maybe split the commit into three: arch/arm*, arch/riscv, console.
Done, this is the first patch, two others will follow :)
https://review.coreboot.org/c/coreboot/+/74173/comment/c99e16c9_f7bf496e PS1, Line 9: This is my first commit to coreboot, so please tell me if I'm missing something.
Possible unwrapped commit description (prefer a maximum 72 chars per line) […]
Done
https://review.coreboot.org/c/coreboot/+/74173/comment/5862c323_5920106f PS1, Line 9: This is my first commit to coreboot, so please tell me if I'm missing something.
Welcome to coreboot. This could be added as a comment, but does not belong into the commit message.
Done
Patchset:
PS2: Thank you for your time and tips!
-
Philipp M (Code Review)