Attention is currently required from: Tim Wawrzynczak.
Malik Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59563 )
Change subject: mb/google/brya/variants/primus: update gpios for power consumption
......................................................................
Patch Set 5:
(2 comments)
File src/mainboard/google/brya/variants/primus/variant.c:
https://review.coreboot.org/c/coreboot/+/59563/comment/9f9f37a0_c202f324
PS4, Line 46: get_sku_and_set_gpio
suggestion: […]
Done
https://review.coreboot.org/c/coreboot/+/59563/comment/cb729f30_c9d6a709
PS4, Line 48: int sku = gpio_get(GPP_T2);
:
: if (sku == 1)
nit: as fars as I can tell, this GPIO is just stuffed on boards with the eMMC, so let's avoid the te […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59563
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I753e41dec1825299e6cd437b5f67e2d957bc6148
Gerrit-Change-Number: 59563
Gerrit-PatchSet: 5
Gerrit-Owner: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Wed, 24 Nov 2021 01:29:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment