Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29669 )
Change subject: cpu/intel/sandybridge: Add `hyper_threading` option ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/29669/8/src/cpu/intel/model_206ax/b... File src/cpu/intel/model_206ax/bootblock.c:
https://review.coreboot.org/c/coreboot/+/29669/8/src/cpu/intel/model_206ax/b... PS8, Line 79: Bit 0 is ht disable
I'm not sure of what read_option returns if it can't find cmos options. […]
It will not compile if it can't find CMOS options.
https://review.coreboot.org/c/coreboot/+/29669/8/src/mainboard/hp/2570p/Kcon... File src/mainboard/hp/2570p/Kconfig:
https://review.coreboot.org/c/coreboot/+/29669/8/src/mainboard/hp/2570p/Kcon... PS8, Line 27: select CPU_INTEL_HT
Why do you add a prompt to this Kconfig option, if it then gets selected anyway? […]
The purpose of this option is to make sure that HT code is included (by a preprocessor) only for selected mainboards. Otherwise many boards will not compile because they do not have CMOS settings. Also, IIRC, some 206ax CPU do not have HT support.
-
Evgeny Zinoviev (Code Review)