Attention is currently required from: Tarun Tuli, Kapil Porwal.
Kun Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74972 )
Change subject: mb/google/rex/var/screebo: Add initial devicetree config
......................................................................
Patch Set 5:
(3 comments)
File src/mainboard/google/rex/variants/screebo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/74972/comment/d07dffeb_c326e1a8
PS4, Line 6: 9
`8`
Done
https://review.coreboot.org/c/coreboot/+/74972/comment/1e80f899_44504e25
PS4, Line 12: OC_SKIP
`OC1`
Done
https://review.coreboot.org/c/coreboot/+/74972/comment/387a4f92_64fa97a0
PS4, Line 281: usb2_port3
PLD for `usb2_port3` and `usb3_port2` should be same. […]
+----------------+
| |
| Screen |
| |
+----------------+
C1 | | C0
| | A0
| | A1
+----------------+
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74972
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie64d0e50ec22b3e363597af64eb723ef1f86dfa8
Gerrit-Change-Number: 74972
Gerrit-PatchSet: 5
Gerrit-Owner: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jinfang Mao
maojinfang@huaqin.corp-partner.google.com
Gerrit-CC: Simon Zhou
zhouguohui@huaqin.corp-partner.google.com
Gerrit-CC: YH Lin
yueherngl@google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Wed, 10 May 2023 13:36:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com
Gerrit-MessageType: comment