Attention is currently required from: Furquan Shaikh, Justin TerAvest, Tim Wawrzynczak, Todd Broch, Aaron Durbin, Patrick Rudolph, Karthik Ramasubramanian.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50127 )
Change subject: drivers/intel/dptf: Add OEM variables support
......................................................................
Patch Set 11:
(4 comments)
File src/acpi/acpigen_dptf.c:
https://review.coreboot.org/c/coreboot/+/50127/comment/b571e143_07941d86
PS11, Line 392: <= 6
`<`
Done
File src/include/acpi/acpigen_dptf.h:
https://review.coreboot.org/c/coreboot/+/50127/comment/946fd143_787dc5cc
PS11, Line 117: 6
Please use a `#define`, e.g. […]
Done
File src/include/acpi/acpigen_dptf.h:
https://review.coreboot.org/c/coreboot/+/50127/comment/71296c2c_90f06bba
PS8, Line 117: uint8_t oem0;
: uint8_t oem1;
: uint8_t oem2;
: uint8_t oem3;
: uint8_t oem4;
: uint8_t oem5;
: };
I wanted to make simple implementation as per https://review.coreboot. […]
Done
https://review.coreboot.org/c/coreboot/+/50127/comment/ff9c96b7_afe6b345
PS8, Line 117: uint8_t oem0;
: uint8_t oem1;
: uint8_t oem2;
: uint8_t oem3;
: uint8_t oem4;
: uint8_t oem5;
: };
I wanted to make simple implementation as per https://review.coreboot. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50127
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf3cf7b40e9a441b41d0c659d76895a58669c2fb
Gerrit-Change-Number: 50127
Gerrit-PatchSet: 11
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Todd Broch
tbroch@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Justin TerAvest
teravest@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Todd Broch
tbroch@chromium.org
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 18 May 2021 18:21:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment