Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37915 )
Change subject: mb/google/peppy: add _DSD to touchscreen ACPI ......................................................................
mb/google/peppy: add _DSD to touchscreen ACPI
Recent changes to the Atmel touchscreen driver in the mainline kernel broke functionality with devices running upstream coreboot, due relying on another driver (chromeos_laptop) which makes the assumption that the i2c devices are be in PCI mode (as with the stock Google firmware) rather than in ACPI mode as they are in upstream coreboot.
Mitigate this by adding the required devicetree property so the Atmel toushcreen driver will correctly attach without the use of chromeos_laptop.
Test: build/boot peppy on 4.18+ kernel, verify touchscreen working
Change-Id: I05df8367886eef55b409590f75a68d98d4e5fbdf Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl 1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/37915/1
diff --git a/src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl b/src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl index cc3e063..4c930de 100644 --- a/src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl +++ b/src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl @@ -140,6 +140,13 @@ } }
+ Name (_DSD, Package () { + ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), + Package () { + Package () {"compatible", "atmel,maxtouch"}, + } + }) + Method (_STA) { If (LEqual (\S2EN, 1)) {
Nicolò Veronese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37915 )
Change subject: mb/google/peppy: add _DSD to touchscreen ACPI ......................................................................
Patch Set 1: Code-Review+1
Tested on 4.18 and 5.0.0. The touchscreen is working on both the kernels.
Nicolò Veronese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37915 )
Change subject: mb/google/peppy: add _DSD to touchscreen ACPI ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
Tested on 4.18 and 5.0.0. The touchscreen is working on both the kernels.
Tested also on Windows 10. All fine.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37915 )
Change subject: mb/google/peppy: add _DSD to touchscreen ACPI ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37915 )
Change subject: mb/google/peppy: add _DSD to touchscreen ACPI ......................................................................
mb/google/peppy: add _DSD to touchscreen ACPI
Recent changes to the Atmel touchscreen driver in the mainline kernel broke functionality with devices running upstream coreboot, due relying on another driver (chromeos_laptop) which makes the assumption that the i2c devices are be in PCI mode (as with the stock Google firmware) rather than in ACPI mode as they are in upstream coreboot.
Mitigate this by adding the required devicetree property so the Atmel toushcreen driver will correctly attach without the use of chromeos_laptop.
Test: build/boot peppy on 4.18+ kernel, verify touchscreen working
Change-Id: I05df8367886eef55b409590f75a68d98d4e5fbdf Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37915 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nicolò Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl 1 file changed, 7 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Nicolò: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl b/src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl index cc3e063..4c930de 100644 --- a/src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl +++ b/src/mainboard/google/slippy/variants/peppy/include/variant/acpi/mainboard.asl @@ -140,6 +140,13 @@ } }
+ Name (_DSD, Package () { + ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), + Package () { + Package () {"compatible", "atmel,maxtouch"}, + } + }) + Method (_STA) { If (LEqual (\S2EN, 1)) {
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)
-
Nicolò Veronese (Code Review)
-
Patrick Georgi (Code Review)