Attention is currently required from: Christian Walter.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79786?usp=email )
Change subject: mb/prodrive/hermes: Change UART from hidden to on
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Does uart_fill_ssdt() still generate valid ACPI code for UART2?
I don't see how code in src/soc/intel/common/block/uart/uart.c actually works using a "generic device". The code was originally written for an UART PCI device...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79786?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If24e1bf920c0b3edaefb4e20af66e33f4ddc1f3f
Gerrit-Change-Number: 79786
Gerrit-PatchSet: 2
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Comment-Date: Thu, 04 Jan 2024 07:11:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment