Attention is currently required from: Kedar J. Karanje, Furquan Shaikh, vagdevi.p@intel.com, Tim Wawrzynczak, Subrata Banik, Vinay Kumar, Balaji Manigandan, Kane Chen, Patrick Rudolph, Baieswara Reddy Sagili. V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56325 )
Change subject: soc/intel/alderlake: Configure the SKU specific parameters for VR domains ......................................................................
Patch Set 9:
(2 comments)
File src/soc/intel/alderlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/56325/comment/93e57ad8_c5f11d67 PS7, Line 51: { PCI_DEVICE_ID_INTEL_ADL_P_ID_3, VR_CFG_ALL_DOMAINS_LOADLINE(2.3, 3.2) }, : { PCI_DEVICE_ID_INTEL_ADL_P_ID_5, VR_CFG_ALL_DOMAINS_LOADLINE(2.3, 3.2) }, : { PCI_DEVICE_ID_INTEL_ADL_P_ID_7, VR_CFG_ALL_DOMAINS_LOADLINE(2.8, 3.2) }, : }; : : static const struct vr_lookup vr_config_icc[] = { : { PCI_DEVICE_ID_INTEL_ADL_P_ID_3, VR_CFG_ALL_DOMAINS_ICC(160, 50) }, : { PCI_DEVICE_ID_INTEL_ADL_P_ID_5, VR_CFG_ALL_DOMAINS_ICC(109, 50) }, : { PCI_DEVICE_ID_INTEL_ADL_P_ID_7, VR_CFG_ALL_DOMAINS_ICC(80, 40) }, : }; : : static const struct vr_lookup vr_config_tdc_enable[] = { : { PCI_DEVICE_ID_INTEL_ADL_P_ID_3, VR_CFG_ALL_DOMAINS_TDC(1, 1) }, : { PCI_DEVICE_ID_INTEL_ADL_P_ID_5, VR_CFG_ALL_DOMAINS_TDC(1, 1) }, : { PCI_DEVICE_ID_INTEL_ADL_P_ID_7, VR_CFG_ALL_DOMAINS_TDC(1, 1) }, : }; : : static const struct vr_lookup vr_config_tdc_timewindow[] = { : { PCI_DEVICE_ID_INTEL_ADL_P_ID_3, VR_CFG_ALL_DOMAINS_TDC(28000, 28000) }, : { PCI_DEVICE_ID_INTEL_ADL_P_ID_5, VR_CFG_ALL_DOMAINS_TDC(28000, 28000) }, : { PCI_DEVICE_ID_INTEL_ADL_P_ID_7, VR_CFG_ALL_DOMAINS_TDC(28000, 28000) }, : }; : : static const struct vr_lookup vr_config_tdc_currentlimit[] = { : { PCI_DEVICE_ID_INTEL_ADL_P_ID_3, VR_CFG_ALL_DOMAINS_TDC_CURRENT(57, 57) }, : { PCI_DEVICE_ID_INTEL_ADL_P_ID_5, VR_CFG_ALL_DOMAINS_TDC_CURRENT(40, 40) }, : { PCI_DEVICE_ID_INTEL_ADL_P_ID_7, VR_CFG_ALL_DOMAINS_TDC_CURRENT(20, 20) },
Also IMHO, https://review.coreboot. […]
@Tim, I updated the details on how these configurations are generated and also created a crossbug for the further discussion-> https://partnerissuetracker.corp.google.com/issues/195033556
https://review.coreboot.org/c/coreboot/+/56325/comment/5ce87fc5_b2e7aaaf PS7, Line 75: { PCI_DEVICE_ID_INTEL_ADL_P_ID_3, VR_CFG_ALL_DOMAINS_TDC_CURRENT(57, 57) }, : { PCI_DEVICE_ID_INTEL_ADL_P_ID_5, VR_CFG_ALL_DOMAINS_TDC_CURRENT(40, 40) }, : { PCI_DEVICE_ID_INTEL_ADL_P_ID_7, VR_CFG_ALL_DOMAINS_TDC_CURRENT(20, 20) }, : };
not from vrtt report. but these settings are according to iPDS PowerMap for ADLP.
.