Attention is currently required from: Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
Julius Werner has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86224?usp=email )
Change subject: soc/intel/alderlake: Display low battery message on screen
......................................................................
Patch Set 16: Code-Review+2
(1 comment)
File src/soc/intel/alderlake/romstage/ux.c:
https://review.coreboot.org/c/coreboot/+/86224/comment/8d83be03_ac8727e3?usp... :
PS16, Line 40:
nit: it's questionable whether these two functions still serve a purpose or whether you may not just want to make the caller pass the ID directly.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86224?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3b24d2c89ade8cc62b7e47c487d52d47b7f3376d
Gerrit-Change-Number: 86224
Gerrit-PatchSet: 16
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Wed, 12 Feb 2025 00:27:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes