Change in ...coreboot[master]: mb/google/hatch: Add Kohaku board

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Shelley Chen (Code Review)

2 Apr 2019 2 Apr '19

3:01 p.m.

Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32161

Change subject: mb/google/hatch: Add Kohaku board ......................................................................

mb/google/hatch: Add Kohaku board

Adding Kohaku as a variant of hatch.

BUG=b:129706980 BRANCH=NONE TEST=./util/abuild/abuild -p none -t google/hatch -x -a make sure HATCH_KOHAKU is built as well.

Change-Id: I5b451f421f6d353005e6b73eac180dcec2e8b0c0 Signed-off-by: Shelley Chen shchen@google.com --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/Kconfig.name 2 files changed, 8 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/32161/1

diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index b551065..dd9abe5 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -59,6 +59,7 @@ depends on CHROMEOS default "HATCH TEST 1823" if BOARD_GOOGLE_HATCH default "HATCH_WHL TEST 2374" if BOARD_GOOGLE_HATCH_WHL + default "KOHAKU TEST CB61" if BOARD_GOOGLE_HATCH_WHL

config MAINBOARD_DIR string @@ -72,6 +73,7 @@ string default "Hatch" if BOARD_GOOGLE_HATCH default "Hatch_whl" if BOARD_GOOGLE_HATCH_WHL + default "Kohaku" if BOARD_GOOGLE_KOHAKU

config MAINBOARD_VENDOR string @@ -93,6 +95,7 @@ string default "hatch" if BOARD_GOOGLE_HATCH default "hatch_whl" if BOARD_GOOGLE_HATCH_WHL + default "kohaku" if BOARD_GOOGLE_KOHAKU

config VBOOT select HAS_RECOVERY_MRC_CACHE diff --git a/src/mainboard/google/hatch/Kconfig.name b/src/mainboard/google/hatch/Kconfig.name index e98bcae..edfa8e7 100644 --- a/src/mainboard/google/hatch/Kconfig.name +++ b/src/mainboard/google/hatch/Kconfig.name @@ -9,3 +9,8 @@ bool "-> Hatch_whl" select BOARD_GOOGLE_BASEBOARD_HATCH select SOC_INTEL_WHISKEYLAKE + +config BOARD_GOOGLE_KOHAKU + bool "-> Kohaku" + select BOARD_GOOGLE_BASEBOARD_HATCH + select SOC_INTEL_COMETLAKE

Attachments:

attachment.htm (text/html — 4.1 KB)

Show replies by date

Furquan Shaikh (Code Review)

2 Apr 2 Apr

3:39 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32161 )

Change subject: mb/google/hatch: Add Kohaku board ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/32161/1/src/mainboard/google/hatch/Kconfig File src/mainboard/google/hatch/Kconfig:

https://review.coreboot.org/#/c/32161/1/src/mainboard/google/hatch/Kconfig@6... PS1, Line 62: CB61 This is supposed to be the last 4-digits of the decimal value.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32161 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b451f421f6d353005e6b73eac180dcec2e8b0c0 Gerrit-Change-Number: 32161 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 02 Apr 2019 22:39:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Shelley Chen (Code Review)

3:51 p.m.

Hello Tim Wawrzynczak, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32161

to look at the new patch set (#2).

Change subject: mb/google/hatch: Add Kohaku board ......................................................................

mb/google/hatch: Add Kohaku board

Adding Kohaku as a variant of hatch.

BUG=b:129706980 BRANCH=NONE TEST=./util/abuild/abuild -p none -t google/hatch -x -a make sure HATCH_KOHAKU is built as well.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/32161/2

Shelley Chen (Code Review)

3:52 p.m.

Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32161 )

Change subject: mb/google/hatch: Add Kohaku board ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/32161/1/src/mainboard/google/hatch/Kconfig File src/mainboard/google/hatch/Kconfig:

https://review.coreboot.org/#/c/32161/1/src/mainboard/google/hatch/Kconfig@6... PS1, Line 62: CB61

...

This is supposed to be the last 4-digits of the decimal value.

Sorry. I knew that. It's the end of the day.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32161 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b451f421f6d353005e6b73eac180dcec2e8b0c0 Gerrit-Change-Number: 32161 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 02 Apr 2019 22:52:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

10:03 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32161 )

Change subject: mb/google/hatch: Add Kohaku board ......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/32161/2/src/mainboard/google/hatch/Kconfig File src/mainboard/google/hatch/Kconfig:

PS2: Just noting so that we have captured this some where. Multiple things need to change here:

1. BOARD_ROMSIZE_KB needs to be different for different variants 2. FMD file needs to be different for different variants. 3. MB_HAS_ACTIVE_HIGH_SD_PWR_ENABLE might not apply to all variants. 4. DIMM_SPD_SIZE will be different for different variants.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32161 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b451f421f6d353005e6b73eac180dcec2e8b0c0 Gerrit-Change-Number: 32161 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 03 Apr 2019 05:03:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

4 Apr 4 Apr

3:34 a.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32161 )

Change subject: mb/google/hatch: Add Kohaku board ......................................................................

mb/google/hatch: Add Kohaku board

Adding Kohaku as a variant of hatch.

BUG=b:129706980 BRANCH=NONE TEST=./util/abuild/abuild -p none -t google/hatch -x -a make sure HATCH_KOHAKU is built as well.

Change-Id: I5b451f421f6d353005e6b73eac180dcec2e8b0c0 Signed-off-by: Shelley Chen shchen@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32161 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/mainboard/google/hatch/Kconfig M src/mainboard/google/hatch/Kconfig.name 2 files changed, 8 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/hatch/Kconfig b/src/mainboard/google/hatch/Kconfig index b551065..f57b410 100644 --- a/src/mainboard/google/hatch/Kconfig +++ b/src/mainboard/google/hatch/Kconfig @@ -59,6 +59,7 @@ depends on CHROMEOS default "HATCH TEST 1823" if BOARD_GOOGLE_HATCH default "HATCH_WHL TEST 2374" if BOARD_GOOGLE_HATCH_WHL + default "KOHAKU TEST 1953" if BOARD_GOOGLE_HATCH_WHL

config MAINBOARD_DIR string @@ -72,6 +73,7 @@ string default "Hatch" if BOARD_GOOGLE_HATCH default "Hatch_whl" if BOARD_GOOGLE_HATCH_WHL + default "Kohaku" if BOARD_GOOGLE_KOHAKU

config MAINBOARD_VENDOR string @@ -93,6 +95,7 @@ string default "hatch" if BOARD_GOOGLE_HATCH default "hatch_whl" if BOARD_GOOGLE_HATCH_WHL + default "kohaku" if BOARD_GOOGLE_KOHAKU

David Wu (Code Review)

7 May 7 May

11:52 p.m.

David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32161 )

Change subject: mb/google/hatch: Add Kohaku board ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/32161/4/src/mainboard/google/hatch/Kconfig File src/mainboard/google/hatch/Kconfig:

https://review.coreboot.org/#/c/32161/4/src/mainboard/google/hatch/Kconfig@6... PS4, Line 62: BOARD_GOOGLE_HATCH_WHL Should be "BOARD_GOOGLE_KOHAKU" ??

-- To view, visit https://review.coreboot.org/c/coreboot/+/32161 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b451f421f6d353005e6b73eac180dcec2e8b0c0 Gerrit-Change-Number: 32161 Gerrit-PatchSet: 4 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Comment-Date: Wed, 08 May 2019 06:52:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

8 May 8 May

12:38 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32161 )

Change subject: mb/google/hatch: Add Kohaku board ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/32161/4/src/mainboard/google/hatch/Kconfig File src/mainboard/google/hatch/Kconfig:

https://review.coreboot.org/#/c/32161/4/src/mainboard/google/hatch/Kconfig@6... PS4, Line 62: BOARD_GOOGLE_HATCH_WHL

...

Should be "BOARD_GOOGLE_KOHAKU" ??

Yes, you are right.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32161 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b451f421f6d353005e6b73eac180dcec2e8b0c0 Gerrit-Change-Number: 32161 Gerrit-PatchSet: 4 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Comment-Date: Wed, 08 May 2019 19:38:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Wu david_wu@quanta.corp-partner.google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

12:42 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32161 )

Change subject: mb/google/hatch: Add Kohaku board ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/32161/4/src/mainboard/google/hatch/Kconfig File src/mainboard/google/hatch/Kconfig:

https://review.coreboot.org/#/c/32161/4/src/mainboard/google/hatch/Kconfig@6... PS4, Line 62: BOARD_GOOGLE_HATCH_WHL

...

Yes, you are right.

Fix here: https://review.coreboot.org/c/coreboot/+/32690

-- To view, visit https://review.coreboot.org/c/coreboot/+/32161 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b451f421f6d353005e6b73eac180dcec2e8b0c0 Gerrit-Change-Number: 32161 Gerrit-PatchSet: 4 Gerrit-Owner: Shelley Chen shchen@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Shelley Chen shchen@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: David Wu david_wu@quanta.corp-partner.google.com Gerrit-Comment-Date: Wed, 08 May 2019 19:42:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Wu david_wu@quanta.corp-partner.google.com Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

2020

days inactive

2056

days old

coreboot-gerrit@coreboot.org

8 comments

4 participants

tags (0)

participants (4)

David Wu (Code Review)
Furquan Shaikh (Code Review)
Patrick Georgi (Code Review)
Shelley Chen (Code Review)