Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25446 )
Change subject: soc/intel/denverton_ns: Generate ACPI DMAR Table
......................................................................
Patch Set 18: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/25446/18/src/soc/intel/denverton_ns...
File src/soc/intel/denverton_ns/acpi.c:
https://review.coreboot.org/c/coreboot/+/25446/18/src/soc/intel/denverton_ns...
PS18, Line 339: MCH_VTBAR_MASK;
nit: this would fit in 96 chars
https://review.coreboot.org/c/coreboot/+/25446/18/src/soc/intel/denverton_ns...
PS18, Line 354: fsp
FSP
https://review.coreboot.org/c/coreboot/+/25446/18/src/soc/intel/denverton_ns...
PS18, Line 359: drdh
DRHD
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25446
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I263b03b96280599266d4c5e193583ecdfe9697b7
Gerrit-Change-Number: 25446
Gerrit-PatchSet: 18
Gerrit-Owner: Julien Viard de Galbert
coreboot-review-ju@vdg.name
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Julien Viard de Galbert
coreboot-review-ju@vdg.name
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Comment-Date: Thu, 19 Mar 2020 15:24:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment