Attention is currently required from: Jonathan Zhang, Johnny Lin, Paul Menzel, David Hendricks, Angel Pons, Shuo Liu, Arthur Heymans, Nill Ge, Patrick Rudolph.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73392 )
Change subject: mb/ibm: Add 4 SPR sockets server board IBM SBP1
......................................................................
Patch Set 11:
(2 comments)
File src/mainboard/ibm/sbp1/Kconfig:
https://review.coreboot.org/c/coreboot/+/73392/comment/0fb83879_d971cefc
PS9, Line 31: MAX_SOCKET_UPD
MAX_SOCKET_UPD matches with how the FSP was built. […]
Done
File src/mainboard/ibm/sbp1/include/spr_sbp1_gpio.h:
https://review.coreboot.org/c/coreboot/+/73392/comment/ee5c0824_864bcc54
PS10, Line 8: static const struct pad_config gpio_table[] = {
Add this to a compilation unit rather than a header?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73392
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie21c744224e8d9e5232d63b8366d2981c9575d70
Gerrit-Change-Number: 73392
Gerrit-PatchSet: 11
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Nill Ge
geshijian@bytedance.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Nill Ge
geshijian@bytedance.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 12 Apr 2023 15:46:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment