Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69670 )
Change subject: nb/intel/ironlake,sandybridge/gma: Fix out() parameter order ......................................................................
nb/intel/ironlake,sandybridge/gma: Fix out() parameter order
Change-Id: I4baa2e06d336736caf5505a05ed4353bcbfdb517 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/69670 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Elyes Haouas ehaouas@noos.fr --- M src/northbridge/intel/ironlake/gma.c M src/northbridge/intel/sandybridge/gma.c 2 files changed, 22 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Elyes Haouas: Looks good to me, approved Arthur Heymans: Looks good to me, but someone else must approve Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/northbridge/intel/ironlake/gma.c b/src/northbridge/intel/ironlake/gma.c index 8084560..fb21d35 100644 --- a/src/northbridge/intel/ironlake/gma.c +++ b/src/northbridge/intel/ironlake/gma.c @@ -122,15 +122,15 @@ /* clear DMISCI status */ reg16 = inw(DEFAULT_PMBASE + TCO1_STS); reg16 &= DMISCI_STS; - outw(DEFAULT_PMBASE + TCO1_STS, reg16); + outw(reg16, DEFAULT_PMBASE + TCO1_STS);
/* clear acpi tco status */ - outl(DEFAULT_PMBASE + GPE0_STS, TCOSCI_STS); + outl(TCOSCI_STS, DEFAULT_PMBASE + GPE0_STS);
/* enable acpi tco scis */ reg16 = inw(DEFAULT_PMBASE + GPE0_EN); reg16 |= TCOSCI_EN; - outw(DEFAULT_PMBASE + GPE0_EN, reg16); + outw(reg16, DEFAULT_PMBASE + GPE0_EN); }
static void gma_func0_init(struct device *dev) diff --git a/src/northbridge/intel/sandybridge/gma.c b/src/northbridge/intel/sandybridge/gma.c index d1b9263..3eed5cc 100644 --- a/src/northbridge/intel/sandybridge/gma.c +++ b/src/northbridge/intel/sandybridge/gma.c @@ -570,15 +570,15 @@ /* Clear DMISCI status */ reg16 = inw(DEFAULT_PMBASE + TCO1_STS); reg16 &= DMISCI_STS; - outw(DEFAULT_PMBASE + TCO1_STS, reg16); + outw(reg16, DEFAULT_PMBASE + TCO1_STS);
/* Clear ACPI TCO status */ - outl(DEFAULT_PMBASE + GPE0_STS, TCOSCI_STS); + outl(TCOSCI_STS, DEFAULT_PMBASE + GPE0_STS);
/* Enable ACPI TCO SCIs */ reg16 = inw(DEFAULT_PMBASE + GPE0_EN); reg16 |= TCOSCI_EN; - outw(DEFAULT_PMBASE + GPE0_EN, reg16); + outw(reg16, DEFAULT_PMBASE + GPE0_EN); }
static void gma_func0_init(struct device *dev)