EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32763
Change subject: mb/google/sarien: Add delay for EC sync ......................................................................
mb/google/sarien: Add delay for EC sync
Kernel will fail at async when go into s0ix. Add a delay to let EC has some time for sync.
BUG=b:130644677 TEST= check event log only log s0ix once
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I7ba48068f44ab2558199277f8dbbbbe9bcf249ff --- M src/soc/intel/cannonlake/acpi/lpit.asl 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/32763/1
diff --git a/src/soc/intel/cannonlake/acpi/lpit.asl b/src/soc/intel/cannonlake/acpi/lpit.asl index 93bce26..9b27c83 100644 --- a/src/soc/intel/cannonlake/acpi/lpit.asl +++ b/src/soc/intel/cannonlake/acpi/lpit.asl @@ -64,6 +64,7 @@ */ If(Arg2 == 5) { _SB.PCI0.LPCB.EC0.S0IX(1) + Sleep(50) /* provide board level s0ix hook */ If (CondRefOf (_SB.MS0X)) { _SB.MS0X(1) @@ -74,6 +75,7 @@ */ If(Arg2 == 6) { _SB.PCI0.LPCB.EC0.S0IX(0) + Sleep(50) /* provide board level s0ix hook */ If (CondRefOf (_SB.MS0X)) { _SB.MS0X(0)
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32763 )
Change subject: mb/google/sarien: Add delay for EC sync ......................................................................
Patch Set 3:
This change is ready for review.
Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32763 )
Change subject: mb/google/sarien: Add delay for EC sync ......................................................................
Patch Set 2:
First if you want to inject a delay, delay in mainboard/EC level will be better instead of under soc directly, also I will recommend to find out why and how long a delay needed. Either some insight info from EC or base on some measurement of board will make more sense to me.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32763 )
Change subject: mb/google/sarien: Add delay for EC sync ......................................................................
Patch Set 3:
Patch Set 2:
First if you want to inject a delay, delay in mainboard/EC level will be better instead of under soc directly, also I will recommend to find out why and how long a delay needed. Either some insight info from EC or base on some measurement of board will make more sense to me.
oh yes... this should move to wilco EC side.
Hello Patrick Rudolph, Simon Glass, Roy Mingi Park, Duncan Laurie, Bora Guvendik, build bot (Jenkins), Furquan Shaikh, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32763
to look at the new patch set (#4).
Change subject: mb/google/sarien: Add delay for EC sync ......................................................................
mb/google/sarien: Add delay for EC sync
Kernel will fail at async when go into s0ix. Add a delay to let EC has some time for sync.
BUG=b:130644677 TEST= check event log only log s0ix once
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I7ba48068f44ab2558199277f8dbbbbe9bcf249ff --- M src/ec/google/wilco/acpi/ec.asl 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/32763/4
Hello Patrick Rudolph, Simon Glass, Roy Mingi Park, Duncan Laurie, Bora Guvendik, build bot (Jenkins), Furquan Shaikh, Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32763
to look at the new patch set (#5).
Change subject: mb/google/sarien: Add delay for EC sync ......................................................................
mb/google/sarien: Add delay for EC sync
Kernel will fail at async when go into s0ix. Add a delay to let EC has some time for sync.
BUG=b:130644677 TEST= check event log only log s0ix once
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I7ba48068f44ab2558199277f8dbbbbe9bcf249ff --- M src/ec/google/wilco/acpi/ec.asl 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/32763/5
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32763 )
Change subject: mb/google/sarien: Add delay for EC sync ......................................................................
Patch Set 5:
Patch Set 2:
First if you want to inject a delay, delay in mainboard/EC level will be better instead of under soc directly, also I will recommend to find out why and how long a delay needed. Either some insight info from EC or base on some measurement of board will make more sense to me.
I tested with some value and I think 20ms is better. 10ms has the fail rate. The suspend abort time is range 15~18ms.
EricR Lai has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32763 )
Change subject: mb/google/sarien: Add delay for EC sync ......................................................................
Abandoned
this issue will fix in kernel
-
EricR Lai (Code Review) -
Lijian Zhao (Code Review)