Attention is currently required from: Hung-Te Lin, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85665?usp=email )
Change subject: soc/mediatek: Add support for MediaTek firmware support package
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
File src/soc/mediatek/common/mtk_fsp.c:
https://review.coreboot.org/c/coreboot/+/85665/comment/22b55d83_3a0354f7?usp... :
PS2, Line 92: prog_set_entry(&fsp, prog_entry(&fsp), intf);
`prog_set_entry` should be sufficient. […]
I meant changing `prog_set_entry` to `prog_set_arg`. We don't need to reset `prog->entry` to the same value.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85665?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idef3518f9763fe5f74adb459c137db164563e483
Gerrit-Change-Number: 85665
Gerrit-PatchSet: 6
Gerrit-Owner: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Fri, 20 Dec 2024 09:28:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com