Attention is currently required from: Hung-Te Lin, Jarried Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/86371?usp=email )
Change subject: soc/mediatek/mt8196: Set MT6316 deglitch time from 2ns to 4ns
......................................................................
Patch Set 1:
(2 comments)
File src/soc/mediatek/common/include/soc/mt6316.h:
https://review.coreboot.org/c/coreboot/+/86371/comment/ab12b970_86c85f63?usp... :
PS1, Line 32: RG
Remove `RG`. Other values here are also registers, but without `RG` in the names.
Also remove `_ADDR`?
File src/soc/mediatek/common/mt6316.c:
https://review.coreboot.org/c/coreboot/+/86371/comment/074ddc26_a505e9e7?usp... :
PS1, Line 177: 0xA
0x0A
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86371?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I77bd50cc6c25d6dcded57d9d65d92a0dd19c3c86
Gerrit-Change-Number: 86371
Gerrit-PatchSet: 1
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Wed, 12 Feb 2025 07:33:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No