Change in coreboot[master]: cbfs: Remove prog_locate() for stages and rmodules

[Julius Werner (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Furquan Shaikh, Marshall Dawson, Patrick Rudolph, Felix Held.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49335 )

Change subject: cbfs: Remove prog_locate() for stages and rmodules
......................................................................

Patch Set 15:

(1 comment)

File src/lib/cbfs.c:

https://review.coreboot.org/c/coreboot/+/49335/comment/f706d308_3f1876c1 
PS15, Line 398: 	if ((err = cbfs_boot_lookup(prog_name(pstage), false, &mdata, &rdev)))
> Should we disable this check in checkpatch?

In my opinion, yes. I find that this construct can be good for readability in some situations (particularly when used with `while` which checkpatch doesn't flag, but if the `while` version is allowed I see no reason why the `if` shouldn't be).

(While we're at it I feel we could also disable UNNECESSARY_ELSE, I don't really see a reason to aggressively disallow that. I think having that else can make things more readable for simple one-or-the-other functions like https://review.coreboot.org/plugins/gitiles/coreboot/+/refs/heads/master/src...).