Attention is currently required from: Angel Pons. Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54375 )
Change subject: mb/asus/p8h61-m_lx: Transform into variant setup ......................................................................
Patch Set 2: Code-Review+2
(2 comments)
File src/mainboard/asus/h61-series/Kconfig:
https://review.coreboot.org/c/coreboot/+/54375/comment/b5ec6ee7_02387d5e PS2, Line 52: default "-S --whitelist EFFS,FCRS" Should this default be only `if BOARD_ASUS_P8H61_M_LX`?
File src/mainboard/asus/h61-series/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/54375/comment/a3f7de57_bc432b42 PS2, Line 6: 0x20171231 I set this to the date I created the DSDT, but only to make it look nice. I am not sure whether anything depends on the version, but I assume changing it wouldn't break anything. Perhaps it would be better to increase and unify the revision number for all the H61 boards? Then there is no board-specific workaround, and anything relying on the version number would surely anticipate a version increase.
-
Tristan Corrick (Code Review)