Attention is currently required from: Yidi Lin, Yu-Ping Wu.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77193?usp=email )
Change subject: libpayload/cbfs: Fill size_out even if cbfs_map() fails ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1: I don't mind the change but I'm a bit reluctant to say that it's okay to look at size_out when the operation fails, because there are many different ways in which a CBFS access can fail and not all of them return a valid size. I guess if you just want to print it in an error message that's fine (make sure you zero-initialize it beforehand), but I don't think you should try anything more fancy with it.
File payloads/libpayload/libcbfs/cbfs.c:
https://review.coreboot.org/c/coreboot/+/77193/comment/c3120beb_7703b104 : PS1, Line 169: } I think you're not setting it in this path now.