Change in coreboot[master]: FSP 2.0: Add fsp_relax_security - coreboot-gerrit

19 Mar 2020


      Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25437 )
Change subject: FSP 2.0: Add fsp_relax_security
......................................................................
Patch Set 18:
(1 comment)
https://review.coreboot.org/c/coreboot/+/25437/18/src/drivers/intel/fsp2_0/n... 
File src/drivers/intel/fsp2_0/notify.c:
https://review.coreboot.org/c/coreboot/+/25437/18/src/drivers/intel/fsp2_0/n... 
PS18, Line 70: fsp_relax_security
Maybe rename this to sound less like an action? E. g.: `should_fsp_relax_security`, `is_fsp_security_relaxed`...
Or even, don't we have something like CHIPSET_LOCKDOWN_COREBOOT ?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/25437
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I972e7387c2612ee0053df21afb55b0b264961174
Gerrit-Change-Number: 25437
Gerrit-PatchSet: 18
Gerrit-Owner: Julien Viard de Galbert coreboot-review-ju@vdg.name
Gerrit-Reviewer: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Reviewer: David Guckian
Gerrit-Reviewer: Julien Viard de Galbert coreboot-review-ju@vdg.name
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Vanessa Eusebio vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Aaron Durbin adurbin@chromium.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Lijian Zhao lijian.zhao@intel.com
Gerrit-Comment-Date: Thu, 19 Mar 2020 15:28:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment