Attention is currently required from: Tarun Tuli, John Zhao, Kapil Porwal.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67742 )
Change subject: mb/google/rex: Enable TCSS DisplayPort detection at preboot
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/rex/Kconfig:
https://review.coreboot.org/c/coreboot/+/67742/comment/4a7fd760_f51419c7
PS7, Line 30: RUN_FSP_GOP
yes, no need in terms of functionality. It was simply aligned with brya's setting. […]
IIRC, Brya had issue on FSP at first. So we may unselect the GOP on chrome tree. This why Brya need it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67742
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1a8a13e937c7132696aa39d85c3c6b6fb2dd13a5
Gerrit-Change-Number: 67742
Gerrit-PatchSet: 7
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: John Zhao
john.zhao@intel.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: John Zhao
john.zhao@intel.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: John Zhao
john.zhao@intel.com
Gerrit-Comment-Date: Fri, 18 Nov 2022 03:56:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: John Zhao
john.zhao@intel.corp-partner.google.com
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment