Change in coreboot[master]: lib/cbfs.c: Fix return value of failure to measure - coreboot-gerrit

26 Feb 2021


      Attention is currently required from: Johnny Lin, Julius Werner, Arthur Heymans, Deomid "rojer" Ryabkov.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51099 )
Change subject: lib/cbfs.c: Fix return value of failure to measure
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51099/comment/3190f211_8a1e50c2 
PS1, Line 10: bootable.
...
...
Instead of allowing failure to measure, should we choose not to measure at certain conditions, als […]
Makes sense. On the other hand, when S-ACM figured out the image is not signed correctly, should coreboot not attempt to measure?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/51099
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd20e543d3b30de045c0656eccdcc494c2fb10ce
Gerrit-Change-Number: 51099
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Deomid "rojer" Ryabkov rojer9@fb.com
Gerrit-Reviewer: Johnny Lin Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Jonathan Zhang jonzhang@fb.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Johnny Lin Johnny_Lin@wiwynn.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Deomid "rojer" Ryabkov rojer9@fb.com
Gerrit-Comment-Date: Fri, 26 Feb 2021 19:26:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang jonzhang@fb.com
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment