Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45196 )
Change subject: mb/google/dedede: Enable SaGv support ......................................................................
Patch Set 4: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/45196/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45196/4//COMMIT_MSG@7 PS4, Line 7: SaGv support Does SaGv support depend on mainboard components (e.g. VR), or can it be enabled on any mainboard?
I've been thinking about moving the SaGv settings to Kconfig, so that one can easily choose which mode to use without having to edit the devicetree.
https://review.coreboot.org/c/coreboot/+/45196/4//COMMIT_MSG@9 PS4, Line 9: nit: no space before the comma
https://review.coreboot.org/c/coreboot/+/45196/4//COMMIT_MSG@11 PS4, Line 11: same here
-
Angel Pons (Code Review)